Review main Merged

70811[TASK] Add missing breaking.rst about service injection in validators

Torben Hansen CR +2 V +2 Normal +79 −0 updated 10/07/21, 10:39

Commit message

With #92238 the objectManager usage has been removed in Extbase
validationResolver. In the same patch it is also mentioned, that
validators must not have services injected. The possibility to
inject services in validators has been removed with #94451.

This change adds a breaking.rst document about the topic and
how to migrate existing code in extensions.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 57

  1. Torben Hansen uploaded patch set 1 08/29/21, 11:44

  2. core-ci voted on patch set 1 V +1 08/29/21, 12:11 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15810

  3. Christian Kuhn rebased onto patch set 2 10/07/21, 10:16

  4. core-ci voted on patch set 2 V +1 10/07/21, 10:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17726

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 10/07/21, 10:38

  6. Benni Mack voted on patch set 2 V +2 CR +2 10/07/21, 10:39

  7. Benni Mack merged patch set 3 10/07/21, 10:39