Review main Merged

70812[TASK] Generate absolute FAL URLs in backend

Helmut Hummel CR +2 V +2 Normal +116 −95 updated 08/31/21, 13:09

Commit message

With #93048 and #93048 every backend usage
of public FAL urls were touched and passed through
PathUtility::getAbsoluteWebPath()

This change introduces a different approach to
register an event listener in a backend middleware,
which makes all public URLs absolute.

With this, all PathUtility::getAbsoluteWebPath calls
for FAL assets became obsolete and are removed again.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 3

Files 22

Show 2 more files

Review log 912

  1. Helmut Hummel uploaded patch set 1 08/29/21, 12:54

  2. core-ci voted on patch set 1 V -1 08/29/21, 13:14 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15813

  3. Helmut Hummel uploaded patch set 2 08/29/21, 23:50

  4. core-ci voted on patch set 2 V -1 08/30/21, 00:10 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15832

  5. Helmut Hummel uploaded patch set 3 08/30/21, 12:31

  6. core-ci voted on patch set 3 V +1 08/30/21, 12:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15862

  7. Benni Mack voted on patch set 3 V +1 CR +1 08/30/21, 16:56

  8. Oli Bartsch voted on patch set 3 V +1 CR +1 08/30/21, 19:59

  9. Benni Mack voted on patch set 3 V +2 CR +2 08/30/21, 20:34

  10. Benni Mack merged patch set 4 08/30/21, 20:34

  11. Stephan Großberndt commented on patch set 4 08/31/21, 08:45

    Image.php:61

    Was this planned as part of this change and forgotten or is there an upcoming change to deprecate it?
  12. Helmut Hummel commented on patch set 4 08/31/21, 13:09

    Image.php:61 Reply Unresolved

    This was overseen, when deprecating the FAL API and should be fixed in a separate change, as this one was meant to fix something unrelated