Review main Merged

70818[BUGFIX] Make impexp export sorting determistic

Stefan Bürk CR +2 V +2 Easy +3 −0 updated 08/30/21, 10:56

Commit message

Add uid as sorting criteria for export data retrievement
to get determistic sorting across dbms and dbms versions.

$ Build/Scripts/runTests.sh -s functional -d postgres -k 12 \
  typo3/sysext/impexp/Tests/Functional/ImportExportTest.php

$ Build/Scripts/runTests.sh -s functional -d postgres -k 13 \
  typo3/sysext/impexp/Tests/Functional/ImportExportTest.php

Review

  • Code review CR +2 Done
    • Tymoteusz Motylewski +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Tymoteusz Motylewski +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Stefan Bürk uploaded patch set 1 08/30/21, 08:33

  2. core-ci voted on patch set 1 V +1 08/30/21, 08:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15844

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 08/30/21, 09:08

  4. Tymoteusz Motylewski voted on patch set 1 V +2 CR +2 08/30/21, 10:49

  5. Tymoteusz Motylewski merged patch set 2 08/30/21, 10:56