70819[FEATURE] Support multiple starting points in selectTree
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 13
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php+79 −23
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaCategory.php3+6 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaSelectTreeItems.php+7 −1
- typo3/sysext/backend/Classes/Security/CategoryPermissionsAspect.php+25 −20
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaCategoryTest.php+68 −2
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectTreeItemsTest.php2+101 −2
- typo3/sysext/core/Classes/Migrations/TcaMigration.php8+33 −0
- typo3/sysext/core/Classes/Tree/TableConfiguration/DatabaseTreeDataProvider.php4+82 −18
- typo3/sysext/core/Classes/Tree/TableConfiguration/TreeDataProviderFactory.php+7 −2
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-95037-RootUidRelatedSettingOfTrees.rstnew+52 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-95037-NewStartingPointsSettingForFormEngineTreeConfig.rstnew+48 −0
- typo3/sysext/core/Tests/Unit/Migrations/TcaMigrationTest.php+110 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+14 −0
Review log 2131
Show 56 earlier messages
-
Andreas Kienast uploaded patch set 1 08/30/21, 09:20
-
core-ci voted on patch set 1 V -1 08/30/21, 09:39 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15846
-
Oli Bartsch commented on patch set 1 08/30/21, 09:44
TcaSelectTreeItemsTest.php:258Maybe we should stick to csv here to not overcomplicate things for integrators. See for example "nonSelectableLevels". Why should an integrator configure uids in two different ways for the same element. -
Andreas Kienast commented on patch set 1 08/30/21, 10:08
TcaCategory.php:139ReplyThanks, great idea.TcaSelectTreeItemsTest.php:258Reply UnresolvedIMO it's cleaner to use arrays where multiple values are accepted, this saves some overhead with string-to-array conversions and such. I don't have hard feelings here, we can do a GU:intExplode() where this setting is evaluated as well. -
Andreas Kienast commented on patch set 1 08/30/21, 10:17
TcaCategory.php:139Reply UnresolvedAh, here it's about PageTS. AFAICS this is not covered by TcaMigration. -
Andreas Kienast uploaded patch set 2 08/30/21, 10:25
-
Andreas Kienast uploaded patch set 3 08/30/21, 10:26
-
core-ci voted on patch set 2 V -1 08/30/21, 10:44 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15851
-
core-ci voted on patch set 3 V -1 08/30/21, 10:45 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15852
-
Andreas Kienast uploaded patch set 4 08/30/21, 11:57
-
core-ci voted on patch set 4 V +1 08/30/21, 12:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15860
-
Andreas Kienast uploaded patch set 5 08/30/21, 14:48
-
Andreas Kienast updated the commit message in patch set 6 08/30/21, 14:48
-
core-ci voted on patch set 6 V +1 08/30/21, 15:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15875
-
core-ci voted on patch set 5 V -1 08/30/21, 15:15 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15874
-
Oli Bartsch commented on patch set 6 08/30/21, 19:43
TcaMigration.php:527treeConfigTcaMigration.php:532Let's also add tests for this new migration.TcaMigration.php:532What do you think about migrateRootUidToStartingPoints()?TcaMigration.php:540Could be simplified: (int)($fieldConfig['config']['treeConfig']['rootUid'] ?? 0) !== 0 We may also want to use this as a guard clause, like the other migrations do.DatabaseTreeDataProvider.php:219Shouldn't this trigger a deprecation log entry? Also extension scanner support might be added.DatabaseTreeDataProvider.php:228In case we only deprecate this, we need some compat layer here. Otherwise this looks breaking as it's no longer set anywhere in core. -
Andreas Kienast commented on patch set 6 CR -1 08/30/21, 20:01
TcaMigration.php:527ReplyAckTcaMigration.php:532ReplyAckTcaMigration.php:532ReplyAckTcaMigration.php:540ReplyAckDatabaseTreeDataProvider.php:219Reply UnresolvedI had a deprecation trigger here at first, but wasn't sure if that would spam the log.DatabaseTreeDataProvider.php:228Reply UnresolvedThe setter was previously called in TreeDataProviderFactory, which became obsolete due to the TCA migration. Since the class is not internal, once _could_ use this in 3rd party code. We might should use is there again. -
Andreas Kienast uploaded patch set 7 08/30/21, 20:11
-
Andreas Kienast uploaded patch set 8 08/30/21, 20:19
-
core-ci voted on patch set 7 V +1 08/30/21, 20:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15893
-
core-ci voted on patch set 8 V +1 08/30/21, 20:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15896
-
Oli Bartsch uploaded patch set 9 09/03/21, 10:40
-
Oli Bartsch voted on patch set 9 V +1 CR +1 09/03/21, 10:44
-
core-ci voted on patch set 9 V +1 09/03/21, 10:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16168
-
Oli Bartsch commented on patch set 9 V 0 CR -1 09/03/21, 10:53
On it again -
Oli Bartsch uploaded patch set 10 09/03/21, 11:12
-
core-ci voted on patch set 10 V +1 09/03/21, 11:27 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16169
-
Oli Bartsch voted on patch set 10 V +1 CR +1 09/03/21, 11:39
-
Benni Mack voted on patch set 10 V +1 CR +1 09/03/21, 11:53
-
Andreas Kienast voted on patch set 10 V +2 CR +2 09/03/21, 12:06
-
Andreas Kienast merged patch set 11 09/03/21, 12:06
TcaCategory.php:139