Review main Merged

70821[TASK] Use existing site instance in AbstractItemProvider

Oli Bartsch CR +2 V +2 Normal +38 −49 updated 02/10/23, 09:27

Commit message

Since #94662 it's possible to access the site
configuration in `foreign_table_where` clauses.

The corresponding site configuration was therefore
fetched using the SiteFinder, which is however not
needed as the SiteResolving data provider already
does this.

This path therefore replaces the duplicated call to
SiteFinder by accessing the Site instance, already
present in the result array.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 78

  1. Oli Bartsch uploaded patch set 1 08/30/21, 10:55

  2. Andreas Kienast voted on patch set 1 V +1 CR +1 08/30/21, 11:04

  3. Benni Mack commented on patch set 1 08/30/21, 11:06

    AbstractItemProvider.php:844

    I guess we need "$result['site'] ?? null"
  4. Andreas Kienast commented on patch set 1 08/30/21, 11:13

    AbstractItemProvider.php:844 Reply

    AFAICS it's pre-defined as null in FormDataCompiler.
  5. core-ci voted on patch set 1 V +1 08/30/21, 11:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15854

  6. Benni Mack voted on patch set 1 V +2 CR +2 08/30/21, 11:17

  7. Benni Mack merged patch set 2 08/30/21, 11:17

  8. Oli Bartsch commented on patch set 1 08/30/21, 11:17

    AbstractItemProvider.php:844 Reply Unresolved