Review main Merged

70822[FEATURE] Allow selecting a row by clicking on it

Oli Bartsch CR +2 V +2 Normal +123 −55 updated 08/30/21, 17:05

Commit message

The multi record selection component, introduced
in #94906, is extended for another convenience
method, which allows users to select a row by
clicking on it. This improves workflows on which
multiple records, which are not necessarily next
to each other, should be selected.

Besides selecting single row, also the keyboard
actions, added in #94944, can be used.

The feature has to be enabled manually for every
module, by placing a data attribute on any parent
element of the table rows.

This patch however enables the feature for all
modules, already using the multi record selection.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Michael Schams +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 8

Review log 2025

  1. Oli Bartsch uploaded patch set 1 08/30/21, 12:39

  2. Oli Bartsch updated the commit message in patch set 2 08/30/21, 12:47

  3. core-ci voted on patch set 1 V +1 08/30/21, 12:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15863

  4. core-ci voted on patch set 2 V +1 08/30/21, 13:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15864

  5. Benni Mack voted on patch set 2 V +1 CR +1 08/30/21, 13:14

  6. Benni Mack commented on patch set 3 08/30/21, 13:17

    Published edit on patch set 2.
  7. Benni Mack voted on patch set 3 V +1 CR +1 08/30/21, 13:17

  8. core-ci voted on patch set 3 V +1 08/30/21, 13:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15865

  9. Jochen Roth voted on patch set 3 V +1 CR +1 08/30/21, 13:36

  10. Michael Schams commented on patch set 3 V -1 08/30/21, 13:42

    Should this work in combination with the keyboard shortcuts (https://review.typo3.org/c/Packages/TYPO3.CMS/+/70688)? As far as I can see, it currently doesn't.
  11. Oli Bartsch uploaded patch set 4 08/30/21, 14:42

  12. Oli Bartsch commented on patch set 4 08/30/21, 14:43

    Reply

    Now it does :) Thanks for testing!
  13. Oli Bartsch commented on patch set 4 08/30/21, 14:44

    Reply

    Done
  14. Oli Bartsch commented on patch set 4 V -1 08/30/21, 14:51

    One minor detail in combination with "manuallyChanged" checkboxes has to be fixed.
  15. core-ci voted on patch set 4 V +1 08/30/21, 15:11 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15872

  16. Michael Schams commented on patch set 4 08/30/21, 15:13

    Reply

    Nice!
  17. Michael Schams voted on patch set 4 V +1 08/30/21, 15:13

  18. Oli Bartsch uploaded patch set 5 08/30/21, 15:24

  19. Oli Bartsch commented on patch set 5 08/30/21, 15:25

    Reply

    Fixed one minor detail, you may want to revote.

    Reply

    Done
  20. core-ci voted on patch set 5 V +1 08/30/21, 15:43 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15877

  21. Benni Mack voted on patch set 5 V +1 CR +1 08/30/21, 15:43

  22. Michael Schams voted on patch set 5 V +1 08/30/21, 16:08

  23. Jochen Roth voted on patch set 5 V +1 CR +1 08/30/21, 16:50

  24. Oli Bartsch voted on patch set 5 V +2 CR +2 08/30/21, 17:05

  25. Oli Bartsch merged patch set 6 08/30/21, 17:05