70827[TASK] Extract default inline frontend JavaScript
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Markus Klein +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Markus Klein +1
- core-ci +1 CI
Issues 1
Files 18
- Build/tsconfig.json+4 −0
- typo3/sysext/core/Classes/Html/DefaultSanitizerBuilder.php+1 −13
- typo3/sysext/core/Classes/Page/DefaultJavaScriptAssetTrait.phpnew+62 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-95041-DeprecateFuriemailView-helper.rst2new+52 −0
- typo3/sysext/core/Tests/Functional/Html/DefaultSanitizerBuilderTest.php+1 −10
- typo3/sysext/fluid/Classes/ViewHelpers/Link/EmailViewHelper.php+7 −4
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/EmailViewHelper.php+17 −2
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/EmailViewHelperTest.php+2 −2
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/EmailViewHelperTest.php+2 −2
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php5+21 −23
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+51 −23
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+2 −43
- typo3/sysext/frontend/Classes/Typolink/AbstractTypolinkBuilder.php+1 −0
- typo3/sysext/frontend/Classes/Typolink/EmailLinkBuilder.php+3 −2
- typo3/sysext/frontend/Resources/Public/JavaScript/default_frontend.jsnew+114 −0
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+1 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+9 −9
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+5 −0
Review log 4162
Show 2237 earlier messages
-
Oliver Hader uploaded patch set 1 08/30/21, 20:13
-
Oliver Hader uploaded patch set 2 08/30/21, 20:14
-
core-ci voted on patch set 1 V -1 08/30/21, 20:17 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15894
-
core-ci voted on patch set 2 V -1 08/30/21, 20:34 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15895
-
Benjamin Franzke commented on patch set 2 CR -1 08/31/21, 08:57
-
Benjamin Franzke commented on patch set 2 08/31/21, 08:59
AbstractMenuContentObject.php:1353ReplyTo clarify "break": "breaking" in a way that the javascript is added as file, although the configurations intent was to remove the javascript. -
Oliver Hader uploaded patch set 3 08/31/21, 09:20
-
Oliver Hader commented on patch set 3 08/31/21, 09:26
AbstractMenuContentObject.php:1353ReplyI don't understand that... with this change, there is no inline JavaScript anymore... feel free to apply your changes directly. Thx -
core-ci voted on patch set 3 V -1 08/31/21, 09:47 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15918
-
Benjamin Franzke uploaded patch set 4 08/31/21, 10:43
-
Benjamin Franzke commented on patch set 4 08/31/21, 10:43
AbstractMenuContentObject.php:1353ReplyWith config.removeDefaultJS = 1 behaviour.js must not be added to the page output, as that is "default js", and users that set config.removeDefaultJS to 1 do this to avoid any javascript (no matter if inline or external) from being added by EXT:frontend to the output. That means, given the following config: config { spamProtectEmailAddresses = -3 removeDefaultJS = 1 } The following code must not be added to the page output: <script async="async" src="/typo3/sysext/frontend/Resources/Public/JavaScript/behavior.js?1630404271"></script> > feel free to apply your changes directly. Thx Yes, sure, adapted in patchset 3. -
core-ci voted on patch set 4 V -1 08/31/21, 11:01 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15921
-
Oliver Hader uploaded patch set 5 09/01/21, 18:22
-
Oliver Hader commented on patch set 5 09/01/21, 18:23
AbstractMenuContentObject.php:1353Reply@bfr: Thanks for adjusting the code and the explanation! -
core-ci voted on patch set 5 V -1 09/01/21, 18:37 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16023
-
core-ci commented on patch set 5 09/01/21, 18:42 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16023
-
core-ci commented on patch set 5 09/01/21, 19:03 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16023
-
Oliver Hader uploaded patch set 6 09/02/21, 08:04
-
core-ci voted on patch set 6 V +1 09/02/21, 08:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16054
-
Benni Mack commented on patch set 6 09/02/21, 08:25
behavior.js:47should we stick to "var" instead of "let" and "const" for the time being? -
Markus Klein commented on patch set 6 09/02/21, 09:29
obsolete -
Markus Klein commented on patch set 6 09/02/21, 09:31
Deprecation-95041-DeprecateFuriemailView-helper.rst:18allowing more -
Oliver Hader uploaded patch set 7 09/02/21, 10:59
-
Oliver Hader commented on patch set 6 09/02/21, 10:59
Deprecation-95041-DeprecateFuriemailView-helper.rst:18ReplyAckbehavior.js:47Reply Unresolvedconst and let are supported in IE11, not in IE10. But fine to change that.. -
Oliver Hader commented on patch set 7 09/02/21, 10:59
Reply
Ack -
core-ci voted on patch set 7 V -1 09/02/21, 11:19 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16067
-
core-ci voted on patch set 7 V +1 09/02/21, 11:43 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16067
-
Oliver Hader uploaded patch set 8 09/02/21, 19:59
-
core-ci voted on patch set 8 V +1 09/02/21, 20:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16126
-
Oliver Hader uploaded patch set 9 09/02/21, 20:29
-
Oliver Hader uploaded patch set 10 09/02/21, 20:45
-
core-ci voted on patch set 9 V -1 09/02/21, 21:00 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16132
-
core-ci voted on patch set 10 V -1 09/02/21, 21:03 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16134
-
Oliver Hader uploaded patch set 11 09/02/21, 21:53
-
Oliver Hader uploaded patch set 12 09/02/21, 22:06
-
core-ci voted on patch set 11 V -1 09/02/21, 22:07 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16142
-
core-ci voted on patch set 12 V +1 09/02/21, 22:21 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16144
-
Benni Mack uploaded patch set 13 09/03/21, 09:39
-
Benni Mack voted on patch set 13 V +1 CR +1 09/03/21, 09:39
-
Benni Mack uploaded patch set 14 09/03/21, 09:50
-
Benni Mack voted on patch set 14 V +1 CR +1 09/03/21, 09:50
-
Markus Klein commented on patch set 14 CR +1 09/03/21, 09:55
will try to give this a test soonish -
core-ci voted on patch set 13 V +1 09/03/21, 10:00 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16162
-
core-ci voted on patch set 14 V +1 09/03/21, 10:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16163
-
Benni Mack uploaded patch set 15 09/03/21, 13:34
-
core-ci voted on patch set 15 V +1 09/03/21, 13:50 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16182
-
Benni Mack uploaded patch set 16 09/03/21, 14:08
-
Benni Mack voted on patch set 16 V +1 CR +1 09/03/21, 14:08
-
core-ci voted on patch set 16 V +1 09/03/21, 14:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16190
-
Oliver Hader rebased onto patch set 17 09/03/21, 14:43
-
core-ci voted on patch set 17 V +1 09/03/21, 14:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16196
-
Markus Klein uploaded patch set 18 09/05/21, 20:05
-
Markus Klein voted on patch set 18 CR +1 09/05/21, 20:05
-
Markus Klein voted on patch set 18 V +1 09/05/21, 20:12
-
core-ci voted on patch set 18 V +1 09/05/21, 20:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16294
-
Georg Ringer commented on patch set 18 09/06/21, 06:45
to give this important change more emphasis I would suggest a feature/important rst. also because it changes a bit the frontend output -
Georg Ringer voted on patch set 18 V +1 CR +1 09/06/21, 06:45
-
Oliver Hader voted on patch set 18 V +2 CR +2 09/06/21, 08:45
-
Oliver Hader voted on patch set 18 V 0 CR 0 09/06/21, 08:45
-
Benni Mack voted on patch set 18 V +2 CR +2 09/08/21, 05:50
-
Benni Mack merged patch set 19 09/08/21, 05:50
-
Oliver Hader wrote 09/08/21, 12:35
Topic set to inline-javascript
AbstractMenuContentObject.php:1353