Review main Merged

70828[BUGFIX] Respect includeNotInMenu setting in menu cache hash

Tina Westner CR +2 V +2 Easy +1 −1 updated 09/13/21, 18:10

Commit message

isSubmenu() produces different results depending on the
includeNotInMenu setting, Therefore we need to use separate
cache entries.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Tina Westner +1
    • Wouter Wolters +1
    • Peter Kraume +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Tina Westner +1
    • Wouter Wolters +1
    • Peter Kraume +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1013

  1. Tina Westner uploaded patch set 1 08/31/21, 06:59

  2. Benjamin Franzke updated the commit message in patch set 2 08/31/21, 07:12

  3. core-ci voted on patch set 1 V -1 08/31/21, 07:15 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15905

  4. core-ci voted on patch set 2 V -1 08/31/21, 07:30 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15906

  5. Stefan Bürk uploaded patch set 3 09/12/21, 17:47

  6. Stefan Bürk commented on patch set 3 09/12/21, 17:49

    Rebased and fixed small error to ged rid of warnings in unittests.
  7. core-ci voted on patch set 3 V +1 09/12/21, 17:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16629

  8. Benni Mack voted on patch set 3 CR +1 09/13/21, 06:34

  9. Tina Westner voted on patch set 3 V +1 CR +1 09/13/21, 06:50

  10. Peter Kraume voted on patch set 3 V +1 CR +1 09/13/21, 06:57

  11. Wouter Wolters voted on patch set 3 V +1 CR +1 09/13/21, 17:55

  12. Georg Ringer voted on patch set 3 V +2 CR +2 09/13/21, 18:10

  13. Georg Ringer merged patch set 4 09/13/21, 18:10