Review main Merged

70830[BUGFIX] Exclude Build/composer/ from typescript build

Benjamin Franzke CR +2 V +2 Easy +6 −3 updated 09/01/21, 14:58

Commit message

The Build/composer/ directory (recently added in 95046 )
contains all core files (symlinked) once `composer install`
has been executed, that means both typoscript and typescript
files that end with .ts. This leads to compilation errors.

These files must actually be ignored by `tsc` during `grunt build`.
and should not be compiled at all (wasted ressources).

While at it we also fix the tsconfig.json to include
a trailing newline, in order to comply to our coding guidelines.

Review

  • Code review CR +2 Done
    • Tymoteusz Motylewski +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • Benni Mack +1
  • Verified V +2 Done
    • Tymoteusz Motylewski +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 67

  1. Benjamin Franzke uploaded patch set 1 08/31/21, 08:28

  2. core-ci voted on patch set 1 V +1 08/31/21, 08:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15913

  3. Benni Mack voted on patch set 1 CR +1 09/01/21, 07:53

  4. Wouter Wolters voted on patch set 1 CR +1 09/01/21, 08:35

  5. Georg Ringer voted on patch set 1 V +1 CR +1 09/01/21, 09:51

  6. Tymoteusz Motylewski voted on patch set 1 V +2 CR +2 09/01/21, 14:57

  7. Tymoteusz Motylewski merged patch set 2 09/01/21, 14:58