Review main Merged

70832[BUGFIX] Replace bootstrap button toggle with css based toggle

Nikita Hovratov CR +2 V +2 Easy +21 −22 updated 08/31/21, 13:24

Commit message

Bootstrap 5 dropped the support for data-bs-toggle="buttons".
See: https://github.com/twbs/bootstrap/pull/30650
The replacement is to use the class "btn-check" in combination with the
state of input fields. This has been done in the Localization module.
Some other occurrences didn't rely on the bootstrap js and it was
enough to simply remove the data attribute.

Also remove a forgotten console.log debug.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 69

  1. Nikita Hovratov uploaded patch set 1 08/31/21, 09:17

  2. Nikita Hovratov uploaded patch set 2 08/31/21, 09:20

  3. core-ci voted on patch set 1 V +1 08/31/21, 09:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15916

  4. core-ci voted on patch set 2 V +1 08/31/21, 09:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15917

  5. Oli Bartsch uploaded patch set 3 08/31/21, 11:11

  6. Oli Bartsch voted on patch set 3 V +1 CR +1 08/31/21, 11:11

  7. core-ci voted on patch set 3 V +1 08/31/21, 11:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15923

  8. Benni Mack voted on patch set 3 V +2 CR +2 08/31/21, 13:24

  9. Benni Mack merged patch set 4 08/31/21, 13:24