Review main Merged

70835[FEATURE] Introduce Event for processing actions in File List

Benni Mack CR +2 V +2 Hard +223 −59 updated 09/02/21, 15:39

Commit message

A new PSR-14 based event "ProcessFileListActionsEvent"
is introduced in favor of the existing
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['fileList']['editIconsHook']
hook, which is now marked as deprecated,
along with its interface "FileListEditIconHookInterface"

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 1317

  1. Benni Mack uploaded patch set 1 08/31/21, 12:22

  2. core-ci voted on patch set 1 V +1 08/31/21, 12:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15927

  3. Oli Bartsch uploaded patch set 2 09/02/21, 12:09

  4. Oli Bartsch voted on patch set 2 V +1 CR +1 09/02/21, 12:10

  5. core-ci voted on patch set 2 V +1 09/02/21, 12:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16075

  6. Nikita Hovratov uploaded patch set 3 09/02/21, 14:10

  7. Nikita Hovratov commented on patch set 3 V +1 CR +1 09/02/21, 14:13

    Moved the Form Hook to the namespace "EventListener" to better distinguish between hooks and events. Also fixed text in deprecation log.
  8. core-ci voted on patch set 3 V +1 09/02/21, 14:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16085

  9. Oli Bartsch uploaded patch set 4 09/02/21, 14:54

  10. Oli Bartsch voted on patch set 4 V +1 CR +1 09/02/21, 14:55

  11. Nikita Hovratov commented on patch set 4 09/02/21, 14:57

    Was the rename of the rst file intentional?
  12. Nikita Hovratov commented on patch set 4 09/02/21, 14:58

    Reply

    Oh I see the typo nvm
  13. Nikita Hovratov voted on patch set 4 V +1 CR +1 09/02/21, 14:58

  14. Benni Mack voted on patch set 4 V +1 CR +1 09/02/21, 15:25

  15. core-ci voted on patch set 4 V +1 09/02/21, 15:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16097

  16. Benni Mack voted on patch set 4 V +2 CR +2 09/02/21, 15:39

  17. Benni Mack merged patch set 5 09/02/21, 15:39