Review main Merged

70836[BUGFIX] Keep original request language for shortcuts

Nikita Hovratov CR +2 V +2 Normal +137 −4 updated 05/10/22, 11:35

Commit message

In #89871 (65dc060) a fix was introduced, that
forces the link generation to use the requested
language of shortcuts instead of the current
language of the frontend.

In addition, another call to getPageOverlay was
added. This is in fact not necessary, as overlaying
is already done implicitly in getPageShortcut. This
introduced a falsy behaviour, where shortcuts
without the current language available would create
a URL with the entry point of the fallback language.

This can be fixed by simply using the request
language from the original $menuItem variable before
processing.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1215

  1. Nikita Hovratov uploaded patch set 1 08/31/21, 12:26

  2. core-ci voted on patch set 1 V +1 08/31/21, 12:47 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15929

  3. Benni Mack commented on patch set 1 09/24/21, 14:50

    Can you add a functional test for this @nikita? Would be great. Patch looks good so far. I think there is a Functional Test Suite (SiteLinkGenerator) in EXT.frontend already.
  4. Nikita Hovratov uploaded patch set 2 09/30/21, 19:12

  5. core-ci voted on patch set 2 V +1 09/30/21, 19:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17366

  6. Nikita Hovratov commented on patch set 2 11/12/21, 13:26

    This depends on this patch to be verified first: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72162
  7. Nikita Hovratov commented on patch set 2 CR -1 11/12/21, 15:14

    Tests will come after the old (corrected) tests are merged.
  8. Nikita Hovratov uploaded patch set 3 11/13/21, 08:55

  9. Nikita Hovratov updated the commit message in patch set 4 11/13/21, 08:56

  10. core-ci voted on patch set 4 V +1 11/13/21, 09:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19217

  11. Stefan Bürk voted on patch set 4 V +1 CR +1 11/13/21, 09:50

  12. Benni Mack voted on patch set 4 V +2 CR +2 11/13/21, 10:06

  13. Benni Mack merged patch set 5 11/13/21, 10:06

  14. Oliver Hader commented on patch set 5 05/04/22, 06:42

    Unresolved

    What about back-porting this to 10.4 branch (as mentioned in `Releases:`)?
  15. Christian Kuhn commented on patch set 5 05/10/22, 11:35

    i guess it's kinda late for a backport to v10 now: the issue does not seem to be critical. i'd be fine with skipping the backport.