Review 10.4 Merged

70837[BUGFIX] Make QueryGenerator handle multiple label_alt columns

Tymoteusz Motylewski CR +2 V +2 Easy +1 −1 updated 09/01/21, 11:50

Commit message

The label_alt field in TCA is a comma separated list of database
columns, so it needs to be exploded before being passed into a
database query.

Review

  • Code review CR +2 Done
    • Tymoteusz Motylewski +2
    • Krzysztof Gutkowski +1
  • Verified V +2 Done
    • Tymoteusz Motylewski +2
    • Krzysztof Gutkowski +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Tymoteusz Motylewski uploaded patch set 1 08/31/21, 13:02

  2. core-ci voted on patch set 1 V +1 08/31/21, 13:10 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15932

  3. Krzysztof Gutkowski voted on patch set 1 V +1 CR +1 08/31/21, 13:24

  4. Tymoteusz Motylewski voted on patch set 1 V +2 CR +2 09/01/21, 11:49

  5. Tymoteusz Motylewski merged patch set 2 09/01/21, 11:50