Review main Merged

70841[BUGFIX] Fix clipboard handling in filelist

Oli Bartsch CR +2 V +2 Normal +80 −58 updated 09/01/21, 07:18

Commit message

This resolves some problems on using the clipboard
in the filelist module. Previously it was for
example not possible to transfer files / folders
to the clipboard again, after it was cleared,
since the corresponding GET parameter was kept
in the URL. This is now fixed by assigning the
action to the filelist form.

Further topics:

- Pagination does now use the correct colspan
- setCB and delete actions are now handled
  via multiple record selection events and do
  not longer rely on "trigger classes"
- the superfluous internal "selectedElements"
  array is removed again, since the display of
  actions is handled by the multi record selection
  component anyways

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 914

  1. Oli Bartsch uploaded patch set 1 08/31/21, 14:15

  2. Oli Bartsch updated the commit message in patch set 2 08/31/21, 14:16

  3. core-ci voted on patch set 1 V +1 08/31/21, 14:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15940

  4. core-ci voted on patch set 2 V -1 08/31/21, 14:36 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15941

  5. core-ci voted on patch set 2 V +1 08/31/21, 15:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15941

  6. Benni Mack voted on patch set 2 V +1 CR +1 08/31/21, 15:23

  7. Oli Bartsch uploaded patch set 3 08/31/21, 17:55

  8. Oli Bartsch uploaded patch set 4 08/31/21, 17:59

  9. core-ci voted on patch set 3 V +1 08/31/21, 18:11 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15961

  10. core-ci voted on patch set 4 V +1 08/31/21, 18:15 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15962

  11. Benni Mack voted on patch set 4 V +1 CR +1 08/31/21, 19:28

  12. Christian Kuhn voted on patch set 4 V +1 CR +1 08/31/21, 21:48

  13. Benni Mack voted on patch set 4 V +2 CR +2 09/01/21, 07:18

  14. Benni Mack merged patch set 5 09/01/21, 07:18