Review main Merged

70845[TASK] runTest.sh: Version check docker-compose v2

Jochen Roth CR +2 V +2 Easy +10 −0 updated 09/02/21, 10:09

Commit message

Docker for Mac (and Windows?) currently misuses their
users as canary testers by actively activating an
"experimental" feature toggle which then ships
a docker-compose v2 rc release.

docker-composer v2's yaml parsing however is broken
(you had ONE job!): It does not properly detect strings
as strings and mumbles about this, and worse, it transforms
shell "don't linebreak!" '\' operator into linebreaks. This
breaks our carefully crafted and formatted testing related
docker-compose.yml configuration.

The situation persists for weeks already, there is no
solution except manually disabling this docker for mac
experimental feature toggle.

The patch makes runTests.sh detect docker-composer v2,
exits out with an error message telling the version
is not supported and how to disable it. ddev went with
a similar approach recently.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1215

  1. Jochen Roth uploaded patch set 1 08/31/21, 15:04

  2. core-ci voted on patch set 1 V +1 08/31/21, 15:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15950

  3. Christian Kuhn voted on patch set 1 CR -1 09/01/21, 09:19

  4. Christian Kuhn uploaded patch set 2 09/01/21, 09:36

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 09/01/21, 09:37

  6. Georg Ringer commented on patch set 2 CR -1 09/01/21, 09:41

    runTests.sh:265

    shouldnt it be called DOCKER_COMPOSE_VERSION without the 'R' because it is about docker-compose and not composer?
  7. Christian Kuhn commented on patch set 2 09/01/21, 09:44

    runTests.sh:265 Reply

    good catch. thx.
  8. Christian Kuhn uploaded patch set 3 09/01/21, 09:45

  9. Christian Kuhn voted on patch set 3 V +1 CR +1 09/01/21, 09:46

  10. Christian Kuhn commented on patch set 3 09/01/21, 09:47

    runTests.sh:265 Reply

    Done
  11. core-ci voted on patch set 2 V +1 09/01/21, 09:50 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15995

  12. core-ci voted on patch set 3 V +1 09/01/21, 10:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16000

  13. Benni Mack voted on patch set 3 V +1 CR +1 09/02/21, 09:04

  14. Christian Kuhn voted on patch set 3 V +2 CR +2 09/02/21, 10:09

  15. Christian Kuhn merged patch set 4 09/02/21, 10:09