Review main Merged

70847[BUGFIX] Always set last checked in multi record selection

Oli Bartsch CR +2 V +2 Easy +5 −9 updated 09/01/21, 07:02

Commit message

Since #94944 the multi record selection allows
keyboard shortcuts for an improved UX. It's
for example possible to select ranges. Therefore,
the last checked element and the current target
are used to determine the range.

Any operation in case no valid shortcut is used.
This however prevents the last checked element
from being set. As a result the range determination
did not longer work reliably.

This is fixed by moving the shortcut check into
the already existing guard clause, which does
properly set the last checked element.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 79

  1. Oli Bartsch uploaded patch set 1 08/31/21, 15:56

  2. Oli Bartsch commented on patch set 1 08/31/21, 16:03

  3. core-ci voted on patch set 1 V +1 08/31/21, 16:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15956

  4. Benni Mack voted on patch set 1 V +1 CR +1 08/31/21, 16:36

  5. Christian Kuhn updated the commit message in patch set 2 08/31/21, 21:45

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 08/31/21, 21:46

  7. core-ci voted on patch set 2 V +1 08/31/21, 22:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15974

  8. Benni Mack voted on patch set 2 V +2 CR +2 09/01/21, 07:02

  9. Benni Mack merged patch set 3 09/01/21, 07:02