70848[TASK] Deprecate argument RelationHandler->writeForeignField()
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/core/Classes/Database/RelationHandler.php+13 −3
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+1 −12
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-95062-SkipSortingArgumentOfRelationHandler-writeForeignField.rstnew+41 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodArgumentDroppedMatcher.php+6 −0
Review log 68
-
Stefan Bürk uploaded patch set 1 08/31/21, 19:27
-
core-ci voted on patch set 1 V +1 08/31/21, 19:50 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15966
-
Christian Kuhn commented on patch set 1 CR -1 08/31/21, 20:12
looks good. will just adapt some cosmetical details. -
Christian Kuhn uploaded patch set 2 08/31/21, 21:27
-
core-ci voted on patch set 2 V +1 08/31/21, 21:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15973
-
Christian Kuhn voted on patch set 2 V +1 CR +1 08/31/21, 21:43
-
Benni Mack commented on patch set 2 V +2 CR +2 09/01/21, 07:52
nice. "$callFromImpExp" was never used in TYPO3 Core / ImpExp since 4.x. Also: nice finding! -
Benni Mack merged patch set 3 09/01/21, 07:52