Review main Merged

70848[TASK] Deprecate argument RelationHandler->writeForeignField()

Stefan Bürk CR +2 V +2 Normal +61 −15 updated 09/01/21, 07:52

Commit message

Argument $skipSorting of RelationHandler->writeForeignField()
is used to pass $callFromImpExp from DataHandler.

The ext:impexp related @internal $callFromImpExp DataHandler
property however is never used and thus obsolete itself.

The patch drops DataHandler->$callFromImpExp and deprecates
last RelationHandler->writeForeignField() argument.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 68

  1. Stefan Bürk uploaded patch set 1 08/31/21, 19:27

  2. core-ci voted on patch set 1 V +1 08/31/21, 19:50 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15966

  3. Christian Kuhn commented on patch set 1 CR -1 08/31/21, 20:12

    looks good. will just adapt some cosmetical details.
  4. Christian Kuhn uploaded patch set 2 08/31/21, 21:27

  5. core-ci voted on patch set 2 V +1 08/31/21, 21:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15973

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 08/31/21, 21:43

  7. Benni Mack commented on patch set 2 V +2 CR +2 09/01/21, 07:52

    nice. "$callFromImpExp" was never used in TYPO3 Core / ImpExp since 4.x. Also: nice finding!
  8. Benni Mack merged patch set 3 09/01/21, 07:52