70849[FEATURE] Support PHP 8 style Channel attribute for logger injection
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Nikita Hovratov +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Nikita Hovratov +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 4
- typo3/sysext/core/Classes/DependencyInjection/LoggerAwarePass.php2+27 −1
- typo3/sysext/core/Classes/DependencyInjection/LoggerInterfacePass.php+34 −1
- typo3/sysext/core/Classes/Log/Channel.phpnew+34 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-95079-SupportPHP8StyleChannelAttributeForLoggerInjection.rstnew+83 −0
Review log 1319
-
Benjamin Franzke uploaded patch set 1 08/31/21, 20:18
-
core-ci voted on patch set 1 V +1 08/31/21, 20:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15968
-
Benjamin Franzke uploaded patch set 2 09/02/21, 13:06
-
core-ci voted on patch set 2 V +1 09/02/21, 13:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16081
-
Benjamin Franzke rebased onto patch set 3 09/02/21, 21:27
-
core-ci voted on patch set 3 V +1 09/02/21, 21:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16139
-
Benjamin Franzke uploaded patch set 4 09/03/21, 09:00
Rebase -
core-ci commented on patch set 4 09/03/21, 09:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16157
-
Benni Mack voted on patch set 4 V +1 CR +1 09/03/21, 10:56
-
Nikita Hovratov commented on patch set 4 09/03/21, 13:51
LoggerAwarePass.php:61Is this right? $channel will only be assigned if it's null. -
Benjamin Franzke uploaded patch set 5 09/03/21, 14:01
-
Benjamin Franzke commented on patch set 5 09/03/21, 14:01
LoggerAwarePass.php:61ReplyAck, that was wrong. -
core-ci voted on patch set 5 V +1 09/03/21, 14:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16188
-
Nikita Hovratov uploaded patch set 6 09/03/21, 14:37
-
Nikita Hovratov voted on patch set 6 V +1 CR +1 09/03/21, 14:39
-
core-ci voted on patch set 6 V +1 09/03/21, 14:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16194
-
Benni Mack voted on patch set 6 V +1 CR +1 09/03/21, 15:12
-
Benjamin Franzke voted on patch set 6 V +2 CR +2 09/03/21, 15:49
-
Benjamin Franzke merged patch set 7 09/03/21, 15:50