70850[TASK] Streamline composer.json deficit detector
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Jochen Roth +1
- Nikita Hovratov +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Jochen Roth +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/extensionmanager/Classes/Controller/ExtensionComposerStatusController.php+9 −27
- typo3/sysext/extensionmanager/Classes/Package/ComposerDeficitDetector.php3renamed+15 −27
- typo3/sysext/extensionmanager/Classes/Report/ExtensionComposerStatus.php+6 −6
- typo3/sysext/extensionmanager/Configuration/Services.yaml+3 −0
- typo3/sysext/extensionmanager/Resources/Private/Templates/ExtensionComposerStatus/List.html+1 −1
Review log 1013
-
Helmut Hummel uploaded patch set 1 08/31/21, 20:37
-
Helmut Hummel uploaded patch set 2 08/31/21, 20:45
-
core-ci voted on patch set 1 V -1 08/31/21, 21:02 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15970
-
core-ci voted on patch set 2 V -1 08/31/21, 21:05 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15972
-
Benni Mack uploaded patch set 3 11/05/21, 08:03
-
core-ci voted on patch set 3 V +1 11/05/21, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18924
-
Andreas Kienast voted on patch set 3 CR +1 11/05/21, 08:38
-
Nikita Hovratov commented on patch set 3 V +1 11/05/21, 09:05
-
Jochen Roth voted on patch set 3 V +1 CR +1 11/05/21, 11:13
-
Benni Mack commented on patch set 3 11/05/21, 11:41
ComposerDeficitDetector.php:62Replythe method is public, so I'd say this is a valid check -
Nikita Hovratov commented on patch set 3 CR +1 11/05/21, 11:46
ComposerDeficitDetector.php:62ReplyYeah, you're right. -
Benni Mack voted on patch set 3 V +2 CR +2 11/05/21, 11:53
-
Benni Mack merged patch set 4 11/05/21, 11:53
ComposerDeficitDetector.php:62