Review main Merged

70850[TASK] Streamline composer.json deficit detector

Helmut Hummel CR +2 V +2 Normal +34 −61 updated 11/05/21, 11:53

Commit message

Code for scanning extension folders and populating
information from that, is removed to use already
available API in extension manager.

Therefore the ComposerDeficitDetector, which has
only usages in EM anyway, is moved into the namespace
of EM.

With doing so some folders in typo3conf/ext might be
missed, that do not contain valid extensions,
but for these, providing composer.json suggetions
might not be useful anyway.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Nikita Hovratov +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 1013

  1. Helmut Hummel uploaded patch set 1 08/31/21, 20:37

  2. Helmut Hummel uploaded patch set 2 08/31/21, 20:45

  3. core-ci voted on patch set 1 V -1 08/31/21, 21:02 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15970

  4. core-ci voted on patch set 2 V -1 08/31/21, 21:05 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15972

  5. Benni Mack uploaded patch set 3 11/05/21, 08:03

  6. core-ci voted on patch set 3 V +1 11/05/21, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18924

  7. Andreas Kienast voted on patch set 3 CR +1 11/05/21, 08:38

  8. Nikita Hovratov commented on patch set 3 V +1 11/05/21, 09:05

    ComposerDeficitDetector.php:62

    Can this ever be empty? Looks like ListUtility always returns information for availableExtensions.
  9. Jochen Roth voted on patch set 3 V +1 CR +1 11/05/21, 11:13

  10. Benni Mack commented on patch set 3 11/05/21, 11:41

    ComposerDeficitDetector.php:62 Reply

    the method is public, so I'd say this is a valid check
  11. Nikita Hovratov commented on patch set 3 CR +1 11/05/21, 11:46

    ComposerDeficitDetector.php:62 Reply

    Yeah, you're right.
  12. Benni Mack voted on patch set 3 V +2 CR +2 11/05/21, 11:53

  13. Benni Mack merged patch set 4 11/05/21, 11:53