Review main Abandoned

70853[TASK] Add generics to makeInstance() and friends

Andreas Kienast CR 0 V 0 Hard +200 −74 updated 09/02/21, 16:48

Commit message

PhpStorm has basic support for generics since eversion 2021.2 which comes
in handy as since the same version the "Dynamic Return Type" plugin broke.

Providing the class-string annotation and a proper return generic
supersedes this and recovers the built-in autocompletion.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 79

Show 59 more files

Review log 913

  1. Andreas Kienast uploaded patch set 1 09/01/21, 07:33

  2. Wouter Wolters voted on patch set 1 CR +1 09/01/21, 07:35

  3. core-ci voted on patch set 1 V -1 09/01/21, 07:47 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15983

  4. Andreas Kienast commented on patch set 1 CR -2 09/01/21, 08:18

    Our code-base needs some more annotations to make phpstan happy, will push an example.
  5. Andreas Kienast uploaded patch set 2 09/01/21, 08:19

  6. core-ci voted on patch set 2 V -1 09/01/21, 08:38 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15986

  7. Andreas Kienast uploaded patch set 3 09/01/21, 13:32

  8. core-ci voted on patch set 3 V -1 09/01/21, 13:46 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16013

  9. Andreas Kienast uploaded patch set 4 09/01/21, 20:28

  10. core-ci voted on patch set 4 V -1 09/01/21, 20:40 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16037

  11. Stephan Großberndt commented on patch set 4 09/02/21, 14:24

  12. Andreas Kienast abandoned the change 09/02/21, 16:24

  13. Andreas Kienast commented on patch set 4 09/02/21, 16:48