70853[TASK] Add generics to makeInstance() and friends
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 79
- typo3/sysext/adminpanel/Classes/Service/ModuleLoader.php+1 −1
- typo3/sysext/backend/Classes/Backend/Avatar/Avatar.php+1 −1
- typo3/sysext/backend/Classes/Backend/ToolbarItems/ClearCacheToolbarItem.php+1 −0
- typo3/sysext/backend/Classes/ContextMenu/ContextMenu.php+2 −0
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php+1 −0
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php+2 −0
- typo3/sysext/backend/Classes/Controller/AboutController.php+1 −0
- typo3/sysext/backend/Classes/Controller/BackendController.php+1 −0
- typo3/sysext/backend/Classes/Controller/LoginController.php+3 −2
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php+1 −0
- typo3/sysext/backend/Classes/Form/Element/InputLinkElement.php+3 −1
- typo3/sysext/backend/Classes/Form/FormDataGroup/OnTheFly.php+1 −2
- typo3/sysext/backend/Classes/Form/FormDataGroup/OrderedProviderList.php+1 −1
- typo3/sysext/backend/Classes/Form/NodeFactory.php+8 −5
- typo3/sysext/backend/Classes/Preview/StandardContentPreviewRenderer.php+2 −0
- typo3/sysext/backend/Classes/Template/Components/ButtonBar.php+1 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+3 −0
- typo3/sysext/backend/Classes/View/BackendLayout/ContentFetcher.php+1 −0
- typo3/sysext/backend/Classes/View/PageLayoutView.php+3 −0
- typo3/sysext/core/Classes/Controller/FileDumpController.php+1 −0
Show 59 more files
- typo3/sysext/core/Classes/Core/Bootstrap.php+6 −2
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+9 −0
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php+4 −0
- typo3/sysext/core/Classes/Imaging/IconFactory.php+1 −0
- typo3/sysext/core/Classes/Resource/StorageRepository.php+1 −1
- typo3/sysext/core/Classes/Service/DependencyOrderingService.php+3 −2
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+6 −4
- typo3/sysext/extbase/Classes/Object/Container/Container.php+11 −6
- typo3/sysext/extbase/Classes/Object/ObjectManager.php+3 −2
- typo3/sysext/extbase/Classes/Reflection/ClassSchema/MethodParameter.php+1 −1
- typo3/sysext/felogin/Classes/Service/ValidatorResolverService.php+1 −1
- typo3/sysext/filelist/Classes/FileList.php+1 −0
- typo3/sysext/fluid/Classes/Core/Rendering/RenderingContext.php+4 −0
- typo3/sysext/fluid/Classes/Core/ViewHelper/ViewHelperResolver.php+1 −4
- typo3/sysext/form/Classes/Controller/FormEditorController.php+1 −0
- typo3/sysext/form/Classes/Controller/FormManagerController.php+3 −0
- typo3/sysext/form/Classes/Domain/Configuration/ConfigurationService.php+1 −0
- typo3/sysext/form/Classes/Domain/Factory/AbstractFormFactory.php+1 −0
- typo3/sysext/form/Classes/Domain/Model/FormElements/AbstractFormElement.php+1 −0
- typo3/sysext/form/Classes/Domain/Model/FormElements/AbstractSection.php+1 −0
- typo3/sysext/form/Classes/Domain/Model/FormElements/Section.php+1 −0
- typo3/sysext/form/Classes/Domain/Model/FormElements/UnknownFormElement.php+1 −0
- typo3/sysext/form/Classes/Domain/Model/Renderable/AbstractRenderable.php+2 −1
- typo3/sysext/form/Classes/Domain/Model/FormDefinition.php+2 −2
- typo3/sysext/form/Classes/Domain/Renderer/FluidFormRenderer.php+1 −0
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+5 −0
- typo3/sysext/form/Classes/ViewHelpers/RenderRenderableViewHelper.php+1 −0
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+1 −0
- typo3/sysext/frontend/Classes/ContentObject/Menu/MenuContentObjectFactory.php+3 −2
- typo3/sysext/frontend/Classes/ContentObject/ContentContentObject.php+1 −0
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+14 −6
- typo3/sysext/frontend/Classes/ContentObject/ImageContentObject.php+1 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+2 −0
- typo3/sysext/frontend/Classes/Hooks/MediaItemHooks.php+2 −0
- typo3/sysext/frontend/Classes/Plugin/AbstractPlugin.php+1 −0
- typo3/sysext/frontend/Classes/Typolink/AbstractTypolinkBuilder.php+3 −2
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+1 −0
- typo3/sysext/indexed_search/Classes/Controller/AdministrationController.php+2 −1
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+5 −2
- typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php+3 −1
- typo3/sysext/indexed_search/Classes/Indexer.php+5 −1
- typo3/sysext/info/Classes/Controller/InfoModuleController.php+1 −1
- typo3/sysext/install/Classes/Command/UpgradeWizardListCommand.php+1 −1
- typo3/sysext/install/Classes/Command/UpgradeWizardRunCommand.php+1 −1
- typo3/sysext/install/Classes/Service/UpgradeWizardsService.php+4 −1
- typo3/sysext/install/Classes/Updates/DatabaseRowsUpdateWizard.php+1 −1
- typo3/sysext/linkvalidator/Classes/Report/LinkValidatorReport.php+1 −0
- typo3/sysext/linkvalidator/Classes/LinkAnalyzer.php+1 −0
- typo3/sysext/lowlevel/Classes/ConfigurationModuleProvider/GlobalVariableProvider.php+1 −0
- typo3/sysext/recordlist/Classes/Controller/AbstractLinkBrowserController.php+2 −1
- typo3/sysext/recordlist/Classes/Controller/ElementBrowserController.php+2 −0
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+7 −0
- typo3/sysext/redirects/Classes/Service/RedirectService.php+3 −2
- typo3/sysext/reports/Classes/Report/Status/Status.php+1 −0
- typo3/sysext/reports/Classes/Report/Status/SystemStatus.php+2 −0
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+13 −9
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php+1 −1
- typo3/sysext/workspaces/Classes/Controller/Remote/RemoteServer.php+2 −0
- typo3/sysext/workspaces/Classes/Controller/AjaxDispatcher.php+1 −1
Review log 913
-
Andreas Kienast uploaded patch set 1 09/01/21, 07:33
-
Wouter Wolters voted on patch set 1 CR +1 09/01/21, 07:35
-
core-ci voted on patch set 1 V -1 09/01/21, 07:47 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15983
-
Andreas Kienast commented on patch set 1 CR -2 09/01/21, 08:18
Our code-base needs some more annotations to make phpstan happy, will push an example. -
Andreas Kienast uploaded patch set 2 09/01/21, 08:19
-
core-ci voted on patch set 2 V -1 09/01/21, 08:38 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15986
-
Andreas Kienast uploaded patch set 3 09/01/21, 13:32
-
core-ci voted on patch set 3 V -1 09/01/21, 13:46 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16013
-
Andreas Kienast uploaded patch set 4 09/01/21, 20:28
-
core-ci voted on patch set 4 V -1 09/01/21, 20:40 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16037
-
Stephan Großberndt commented on patch set 4 09/02/21, 14:24
Maybe using .phpstorm.meta.php instead would be better? see https://www.jetbrains.com/help/phpstorm/ide-advanced-metadata.html#type https://github.com/pbyrne84/DynamicReturnTypePlugin/issues/81#issuecomment-911721455 -
Andreas Kienast abandoned the change 09/02/21, 16:24
-
Andreas Kienast commented on patch set 4 09/02/21, 16:48