Review main Merged

70860[TASK] Stabilize acceptance tests

Jochen Roth CR +2 V +2 Easy +16 −13 updated 09/03/21, 10:25

Commit message

Some acceptance tests fail radomly due
to speed/timing of the checked elements
or unresolved promises.

This should be avoided now by using "waitForElements"
instead of "canSeeElement". This may cause longer
test runs but makes sure tests won't fail
on performane hiccups.

On top of that Icon.getIcon in DocumentSaveActions
will catch unresolved promise in case a new page or reload
was triggered by the button to avoid Javascript errors.
For example in Scheduler -> Add Task and hit save.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 718

  1. Jochen Roth uploaded patch set 1 09/01/21, 18:53

  2. core-ci voted on patch set 1 V +1 09/01/21, 19:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16024

  3. core-ci commented on patch set 1 09/01/21, 19:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16025

  4. core-ci commented on patch set 1 09/01/21, 19:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16026

  5. core-ci commented on patch set 1 09/01/21, 19:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16027

  6. core-ci commented on patch set 1 09/01/21, 19:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16028

  7. core-ci commented on patch set 1 09/01/21, 20:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16031

  8. core-ci commented on patch set 1 09/01/21, 20:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16029

  9. core-ci commented on patch set 1 09/01/21, 20:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16030

  10. core-ci commented on patch set 1 09/01/21, 20:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16032

  11. Jochen Roth uploaded patch set 2 09/02/21, 11:56

  12. core-ci voted on patch set 2 V +1 09/02/21, 12:13 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16072

  13. Jochen Roth updated the commit message in patch set 3 09/02/21, 12:18

  14. core-ci voted on patch set 3 V +1 09/02/21, 12:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16076

  15. Benni Mack voted on patch set 3 V +1 CR +1 09/03/21, 09:25

  16. Oliver Klee voted on patch set 3 V +1 CR +1 09/03/21, 09:51

  17. Benni Mack voted on patch set 3 V +2 CR +2 09/03/21, 10:25

  18. Benni Mack merged patch set 4 09/03/21, 10:25