Review main Merged

70861[TASK] Simplify code in list modules

Oli Bartsch CR +2 V +2 Normal +53 −52 updated 09/02/21, 07:03

Commit message

This is a pre-patch for #95068, simplifying
some code in list modules.

In detail:

* Multi record selection now uses a dedicated
  class for modules, adding the actions into
  a "panel"
* To prevent JSON parsing errors, the action
  configuration is now encoded using
  GeneralUtility::jsonEncodeForHtmlAttribute
* The code to add the "new record" button
  in DatabaseRecordList is streamlined

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 69

  1. Oli Bartsch uploaded patch set 1 09/01/21, 20:04

  2. Oli Bartsch uploaded patch set 2 09/01/21, 20:15

  3. core-ci voted on patch set 1 V -1 09/01/21, 20:21 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16035

  4. core-ci voted on patch set 2 V -1 09/01/21, 20:30 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16036

  5. Oli Bartsch uploaded patch set 3 09/01/21, 21:26

  6. core-ci voted on patch set 3 V +1 09/01/21, 21:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16040

  7. Andreas Kienast voted on patch set 3 V +1 CR +1 09/02/21, 06:58

  8. Benni Mack voted on patch set 3 V +2 CR +2 09/02/21, 07:03

  9. Benni Mack merged patch set 4 09/02/21, 07:03