Review main Merged

70862[TASK] Remove outdated phpdoc of GeneralUtility::mkdir_deep()

Elias Häußler CR +2 V +2 Easy +2 −2 updated 09/02/21, 08:15

Commit message

Since #63920 it is no longer required to have a trailing slash for the
first argument $directory in GeneralUtility::mkdir_deep(). Therefore,
the appropriate phpdoc has been adapted to avoid further confusions.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Wouter Wolters +1
    • Riny van Tiggelen +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Wouter Wolters +1
    • Riny van Tiggelen +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Elias Häußler uploaded patch set 1 09/02/21, 06:55

  2. core-ci voted on patch set 1 V +1 09/02/21, 07:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16047

  3. Wouter Wolters voted on patch set 1 V +1 CR +1 09/02/21, 07:24

  4. Riny van Tiggelen voted on patch set 1 V +1 CR +1 09/02/21, 07:41

  5. Oliver Hader voted on patch set 1 V +2 CR +2 09/02/21, 08:15

  6. Oliver Hader merged patch set 2 09/02/21, 08:15