Review main Merged

70863[BUGFIX] Fix undefined array key errors

Nikita Hovratov CR +2 V +2 Easy +8 −3 updated 10/07/21, 12:56

Commit message

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Robert Kärner +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2024

  1. Nikita Hovratov uploaded patch set 1 09/02/21, 09:01

  2. Oliver Klee voted on patch set 1 CR +1 09/02/21, 09:15

  3. Tymoteusz Motylewski commented on patch set 1 09/02/21, 09:17

    can you give some hints in the ticket how to trigger this error?
  4. core-ci voted on patch set 1 V +1 09/02/21, 09:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16058

  5. Nikita Hovratov commented on patch set 1 09/02/21, 09:22

    Reply

    It happened while copying a page with the clipboard.
  6. Tymoteusz Motylewski commented on patch set 1 09/02/21, 13:28

    Reply

    I have tried copy and pasting page with clipboard (list module) and there were no warning/error, neither in UX nor in the log (using PHP8)
  7. Oli Bartsch commented on patch set 1 09/02/21, 15:50

    SimpleDataHandlerController.php:270

    What about: !is_array($this->cmd[$table] ?? null)
  8. Nikita Hovratov commented on patch set 1 09/02/21, 15:52

    SimpleDataHandlerController.php:270 Reply

    Even better
  9. Nikita Hovratov uploaded patch set 2 09/02/21, 15:59

  10. Nikita Hovratov commented on patch set 2 09/02/21, 15:59

    SimpleDataHandlerController.php:270 Reply

    Done
  11. core-ci voted on patch set 2 V -1 09/02/21, 16:15 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16110

  12. Nikita Hovratov uploaded patch set 3 09/02/21, 16:34

  13. Oliver Klee voted on patch set 3 CR +1 09/02/21, 16:49

  14. core-ci voted on patch set 3 V +1 09/02/21, 16:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16112

  15. Jörg Bösche voted on patch set 3 CR +1 09/26/21, 01:34

  16. Benni Mack commented on patch set 3 09/27/21, 11:10

    DataHandler.php:3365

    since $theNewSQLID is going to be returned in this method, this should be "null" instead of "false".
  17. Nikita Hovratov uploaded patch set 4 09/27/21, 14:41

  18. Nikita Hovratov commented on patch set 3 09/27/21, 14:41

    DataHandler.php:3365 Reply

    Done
  19. Oliver Klee voted on patch set 4 CR +1 09/27/21, 14:46

  20. core-ci voted on patch set 4 V +1 09/27/21, 14:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17229

  21. Benni Mack voted on patch set 4 V +1 CR +1 09/28/21, 14:25

  22. Robert Kärner voted on patch set 4 CR +1 09/29/21, 07:27

  23. Georg Ringer voted on patch set 4 V +2 CR +2 10/07/21, 12:56

  24. Georg Ringer merged patch set 5 10/07/21, 12:56