Review main Merged

70864[BUGFIX] TypeError in MoveElementController when using sqlite

Daniel Siepmann CR +2 V +2 Easy +1 −1 updated 09/06/21, 13:04

Commit message

The value fetched from database when using sqlite is of type string.
The property page_id is typed to be integer.
Assigning the string to integer would result in an TypeError.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 912

  1. Daniel Siepmann uploaded patch set 1 09/02/21, 12:01

  2. core-ci voted on patch set 1 V -1 09/02/21, 12:06 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16073

  3. Oliver Klee commented on patch set 1 09/02/21, 12:17

    Is 10.4 affected as well?
  4. Daniel Siepmann uploaded patch set 2 09/02/21, 15:03

  5. Daniel Siepmann commented on patch set 2 09/02/21, 15:05

    Reply Unresolved

    Didn't test, but 10.4 doesn't have types properties. So it will at least not crash in the same way.
  6. core-ci voted on patch set 2 V -1 09/02/21, 15:43 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16102

  7. Daniel Siepmann rebased onto patch set 3 09/06/21, 06:51

  8. Georg Ringer voted on patch set 3 V +1 CR +1 09/06/21, 06:53

  9. core-ci voted on patch set 3 V +1 09/06/21, 07:11 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16303

  10. Oliver Klee voted on patch set 3 CR +1 09/06/21, 11:44

  11. Oli Bartsch voted on patch set 3 V +2 CR +2 09/06/21, 13:04

  12. Oli Bartsch merged patch set 4 09/06/21, 13:04