Review main Merged

70865[FEATURE] Introduce ModifyFileDumpEvent

Benni Mack CR +2 V +2 Normal +211 −9 updated 09/02/21, 20:46

Commit message

A new PSR-14 based event "ModifyFileDumpEvent" is
introduced in favor of the existing
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['FileDumpEID.php']['checkFileAccess']
hook, which is now marked as deprecated, along with
its interface "FileDumpEIDHookInterface".

In contrast to the hook, the new event also contains
the PSR-7 Request and additionally allows to replace
the file, being dumped.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1014

  1. Benni Mack uploaded patch set 1 09/02/21, 12:06

  2. core-ci voted on patch set 1 V +1 09/02/21, 12:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16074

  3. Oli Bartsch uploaded patch set 2 09/02/21, 13:18

  4. core-ci voted on patch set 2 V +1 09/02/21, 13:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16083

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 09/02/21, 13:31

  6. Oli Bartsch uploaded patch set 3 09/02/21, 14:57

  7. Oli Bartsch voted on patch set 3 V +1 CR +1 09/02/21, 15:01

  8. core-ci voted on patch set 3 V +1 09/02/21, 15:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16099

  9. Oli Bartsch uploaded patch set 4 09/02/21, 15:48

  10. core-ci voted on patch set 4 V +1 09/02/21, 16:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16109

  11. Oli Bartsch voted on patch set 4 V +1 CR +1 09/02/21, 19:12

  12. Wouter Wolters voted on patch set 4 V +1 CR +1 09/02/21, 19:19

  13. Benni Mack voted on patch set 4 V +2 CR +2 09/02/21, 20:46

  14. Benni Mack merged patch set 5 09/02/21, 20:46