Review main Abandoned

70866[TASK] Move CSS classes and ids to YAML

rgropp CR 0 V 0 Normal +163 −68 updated 09/28/21, 08:04

Commit message

Until now, CSS classes / ids of the frontend templates
of the Form Framework were not consistently included in
the form configuration. So far some classes / ids were
present in the form configuration, others were
"hard coded" only in the Fluid Templates.

This situation has now been fixed. All CSS classes / ids
are consistently defined in the from configuration.

This simplifies the integration of the frontend. The
change makes it easier for integrators to make upgrades
of the frontend framework. In most cases, it is
now no longer necessary to override a fluid template
for changes to classes / ids. Instead, it is only
necessary to add the appropriate CSS classes / ids to the
form configuration.

The changes are important preparatory work for the
switch to Bootstrap 5 including backward compatibility
with Bootstrap 4 and optimizing accessibility.

Installations that have extended the form configuration
regarding the CSS classes / ids to be used have to check
their configuration and adjust it if necessary.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 46

Show 26 more files

Review log 2231

Show 36 earlier messages
  1. rgropp uploaded patch set 1 09/02/21, 12:57

  2. core-ci voted on patch set 1 V +1 09/02/21, 13:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16080

  3. Björn Jacob uploaded patch set 2 09/02/21, 15:26

  4. Björn Jacob updated the commit message in patch set 3 09/02/21, 15:27

  5. core-ci voted on patch set 2 V +1 09/02/21, 15:47 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16105

  6. core-ci voted on patch set 3 V -1 09/02/21, 15:51 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16106

  1. core-ci voted on patch set 3 V +1 09/03/21, 06:10 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16106

  2. waldhacker commented on patch set 3 CR -1 09/03/21, 12:57

    FormConditionFunctionsProvider.php:12

    This class is not needed by this patchset, right? If this is the case, please remove it.

    Checkbox.yaml:41

    IMHO, this change has nothing to do with the task, does it? If this is the case, please remove it.
  3. waldhacker commented on patch set 3 09/03/21, 13:20

    FormConditionFunctionsProvider.php:12 Reply

    ... I don't mean the whole class but only the changes in the class :)
  4. rgropp uploaded patch set 4 09/03/21, 13:23

  5. waldhacker commented on patch set 4 09/03/21, 13:27

    FormConditionFunctionsProvider.php:12 Reply

    Done

    Checkbox.yaml:41 Reply

    Done
  6. waldhacker commented on patch set 5 09/03/21, 13:27

    Published edit on patch set 4.
  7. Björn Jacob voted on patch set 5 V +1 CR +1 09/03/21, 13:30

  8. core-ci voted on patch set 4 V +1 09/03/21, 13:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16180

  9. core-ci voted on patch set 5 V +1 09/03/21, 13:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16181

  10. rgropp uploaded patch set 6 09/03/21, 13:57

  11. waldhacker updated the commit message in patch set 7 09/03/21, 14:06

  12. core-ci voted on patch set 6 V +1 09/03/21, 14:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16186

  13. waldhacker uploaded patch set 8 09/03/21, 14:22

  14. core-ci voted on patch set 7 V +1 09/03/21, 14:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16189

  15. core-ci voted on patch set 8 V +1 09/03/21, 14:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16192

  16. waldhacker voted on patch set 8 V +1 CR +1 09/03/21, 14:41

  17. Björn Jacob voted on patch set 8 V +1 CR +1 09/03/21, 21:22

  18. waldhacker voted on patch set 8 V 0 CR 0 09/04/21, 07:17

  19. waldhacker commented on patch set 8 CR -1 09/04/21, 08:17

    I'm afraid we can only include this with the launch of v12. The changes are too breaking and can therefore no longer be included in the current release cycle. For example, if someone has overwritten the templates to remove or replace the hardcoded "form-group" in the template because the CSS requires it, then this patchset may cause the "form-group" class to be rendered to the elements again. Therefore, we can only include this in v12 unless we can think of another non-breaking variant.
  20. waldhacker commented on patch set 8 09/04/21, 11:05

    on it
  21. waldhacker commented on patch set 8 09/04/21, 14:10

  22. Björn Jacob voted on patch set 8 V 0 CR 0 09/04/21, 20:38

  23. Oliver Hader commented on patch set 8 CR -1 09/27/21, 17:55

    What shall happen with this change?
  24. Björn Jacob commented on patch set 8 CR -1 09/28/21, 07:24

  25. Oliver Hader abandoned the change 09/28/21, 08:04

    Abandoned as requested