70866[TASK] Move CSS classes and ids to YAML
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 46
- typo3/sysext/core/Documentation/Changelog/master/Important-94869-MoveCSSClassesAndIdsToYAML.rstnew+32 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/AdvancedPassword.yaml+3 −1
- typo3/sysext/form/Configuration/Yaml/FormElements/Checkbox.yaml2+4 −1
- typo3/sysext/form/Configuration/Yaml/FormElements/ContentElement.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Date.yaml+3 −1
- typo3/sysext/form/Configuration/Yaml/FormElements/DatePicker.yaml+3 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Email.yaml+3 −1
- typo3/sysext/form/Configuration/Yaml/FormElements/Fieldset.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/FileUpload.yaml+2 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Form.yaml+15 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/ImageUpload.yaml+2 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/MultiCheckbox.yaml+5 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/MultiSelect.yaml+3 −1
- typo3/sysext/form/Configuration/Yaml/FormElements/Number.yaml+3 −1
- typo3/sysext/form/Configuration/Yaml/FormElements/Password.yaml+3 −1
- typo3/sysext/form/Configuration/Yaml/FormElements/RadioButton.yaml+4 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/SingleSelect.yaml+3 −1
- typo3/sysext/form/Configuration/Yaml/FormElements/StaticText.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/SummaryPage.yaml+4 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Telephone.yaml+3 −1
Show 26 more files
- typo3/sysext/form/Configuration/Yaml/FormElements/Text.yaml+3 −1
- typo3/sysext/form/Configuration/Yaml/FormElements/Textarea.yaml+3 −1
- typo3/sysext/form/Configuration/Yaml/FormElements/Url.yaml+3 −1
- typo3/sysext/form/Resources/Private/Frontend/Partials/Field/Field.html+4 −4
- typo3/sysext/form/Resources/Private/Frontend/Partials/Field/Required.html+1 −1
- typo3/sysext/form/Resources/Private/Frontend/Partials/Form/Navigation.html+9 −9
- typo3/sysext/form/Resources/Private/Frontend/Partials/AdvancedPassword.html+4 −4
- typo3/sysext/form/Resources/Private/Frontend/Partials/Checkbox.html+2 −2
- typo3/sysext/form/Resources/Private/Frontend/Partials/ContentElement.html+2 −2
- typo3/sysext/form/Resources/Private/Frontend/Partials/Date.html+1 −1
- typo3/sysext/form/Resources/Private/Frontend/Partials/DatePicker.html+7 −7
- typo3/sysext/form/Resources/Private/Frontend/Partials/Email.html+1 −1
- typo3/sysext/form/Resources/Private/Frontend/Partials/Fieldset.html+1 −1
- typo3/sysext/form/Resources/Private/Frontend/Partials/MultiCheckbox.html+3 −3
- typo3/sysext/form/Resources/Private/Frontend/Partials/MultiSelect.html+2 −2
- typo3/sysext/form/Resources/Private/Frontend/Partials/Number.html+1 −1
- typo3/sysext/form/Resources/Private/Frontend/Partials/Password.html+1 −1
- typo3/sysext/form/Resources/Private/Frontend/Partials/RadioButton.html+5 −5
- typo3/sysext/form/Resources/Private/Frontend/Partials/SingleSelect.html+2 −2
- typo3/sysext/form/Resources/Private/Frontend/Partials/StaticText.html+1 −1
- typo3/sysext/form/Resources/Private/Frontend/Partials/SummaryPage.html+4 −4
- typo3/sysext/form/Resources/Private/Frontend/Partials/Telephone.html+1 −1
- typo3/sysext/form/Resources/Private/Frontend/Partials/Text.html+1 −1
- typo3/sysext/form/Resources/Private/Frontend/Partials/Textarea.html+1 −1
- typo3/sysext/form/Resources/Private/Frontend/Partials/Url.html+1 −1
- typo3/sysext/form/Resources/Private/Frontend/Templates/Form.html+1 −1
Review log 2231
Show 36 earlier messages
-
rgropp uploaded patch set 1 09/02/21, 12:57
-
core-ci voted on patch set 1 V +1 09/02/21, 13:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16080
-
Björn Jacob uploaded patch set 2 09/02/21, 15:26
-
Björn Jacob updated the commit message in patch set 3 09/02/21, 15:27
-
core-ci voted on patch set 2 V +1 09/02/21, 15:47 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16105
-
core-ci voted on patch set 3 V -1 09/02/21, 15:51 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16106
-
core-ci voted on patch set 3 V +1 09/03/21, 06:10 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16106
-
waldhacker commented on patch set 3 CR -1 09/03/21, 12:57
Checkbox.yaml:41IMHO, this change has nothing to do with the task, does it? If this is the case, please remove it. -
waldhacker commented on patch set 3 09/03/21, 13:20
FormConditionFunctionsProvider.php:12Reply... I don't mean the whole class but only the changes in the class :) -
rgropp uploaded patch set 4 09/03/21, 13:23
-
waldhacker commented on patch set 4 09/03/21, 13:27
FormConditionFunctionsProvider.php:12ReplyDoneCheckbox.yaml:41ReplyDone -
waldhacker commented on patch set 5 09/03/21, 13:27
Published edit on patch set 4. -
Björn Jacob voted on patch set 5 V +1 CR +1 09/03/21, 13:30
-
core-ci voted on patch set 4 V +1 09/03/21, 13:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16180
-
core-ci voted on patch set 5 V +1 09/03/21, 13:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16181
-
rgropp uploaded patch set 6 09/03/21, 13:57
-
waldhacker updated the commit message in patch set 7 09/03/21, 14:06
-
core-ci voted on patch set 6 V +1 09/03/21, 14:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16186
-
waldhacker uploaded patch set 8 09/03/21, 14:22
-
core-ci voted on patch set 7 V +1 09/03/21, 14:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16189
-
core-ci voted on patch set 8 V +1 09/03/21, 14:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16192
-
waldhacker voted on patch set 8 V +1 CR +1 09/03/21, 14:41
-
Björn Jacob voted on patch set 8 V +1 CR +1 09/03/21, 21:22
-
waldhacker voted on patch set 8 V 0 CR 0 09/04/21, 07:17
-
waldhacker commented on patch set 8 CR -1 09/04/21, 08:17
I'm afraid we can only include this with the launch of v12. The changes are too breaking and can therefore no longer be included in the current release cycle. For example, if someone has overwritten the templates to remove or replace the hardcoded "form-group" in the template because the CSS requires it, then this patchset may cause the "form-group" class to be rendered to the elements again. Therefore, we can only include this in v12 unless we can think of another non-breaking variant. -
waldhacker commented on patch set 8 09/04/21, 11:05
on it -
waldhacker commented on patch set 8 09/04/21, 14:10
Maybe obsolete if https://review.typo3.org/c/Packages/TYPO3.CMS/+/70884/ is fine. -
Björn Jacob voted on patch set 8 V 0 CR 0 09/04/21, 20:38
-
Oliver Hader commented on patch set 8 CR -1 09/27/21, 17:55
What shall happen with this change? -
Björn Jacob commented on patch set 8 CR -1 09/28/21, 07:24
Let's abandon it in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/70884/ -
Oliver Hader abandoned the change 09/28/21, 08:04
Abandoned as requested
FormConditionFunctionsProvider.php:12