70867[BUGFIX] Add fallback values for frontend
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
-
Verified V +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php4+3 −3
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php6+8 −8
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+2 −2
- typo3/sysext/frontend/Classes/Http/RequestHandler.php10+80 −80
- typo3/sysext/indexed_search/Classes/FileContentParser.php+1 −1
Review log 3144
Show 1319 earlier messages
-
Jochen Roth uploaded patch set 1 09/02/21, 14:12
-
core-ci voted on patch set 1 V -1 09/02/21, 14:35 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16086
-
Jochen Roth uploaded patch set 2 09/02/21, 14:58
-
core-ci voted on patch set 2 V +1 09/02/21, 15:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16100
-
Christian Kuhn updated the commit message in patch set 3 09/06/21, 14:11
-
Christian Kuhn voted on patch set 3 V +1 CR +1 09/06/21, 14:11
-
core-ci voted on patch set 3 V -1 09/06/21, 14:27 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16328
-
Benni Mack rebased onto patch set 4 09/07/21, 18:54
-
core-ci voted on patch set 4 V +1 09/07/21, 19:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16385
-
Robert Kärner uploaded patch set 5 09/13/21, 07:04
-
core-ci voted on patch set 5 V +1 09/13/21, 07:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16634
-
Robert Kärner uploaded patch set 6 09/13/21, 07:29
-
core-ci voted on patch set 6 V +1 09/13/21, 07:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16635
-
Wouter Wolters voted on patch set 6 CR +1 09/13/21, 17:53
-
Benni Mack commented on patch set 6 09/14/21, 06:26
-
Robert Kärner commented on patch set 6 09/14/21, 06:51
RequestHandler.php:659ReplyI have thought this through, but I might have made a mistake. Let's go through it again together. This is what I think it means: If external is set and is truthy, return false Otherwise, if disableCompression is unset or falsey, return true Otherwise, return false This can be rewritten to: If external is set and is truthy, return false If disableCompression is set and truthy, return false Otherwise, return true Which is what my rewritten code does. And in fact, it still makes sense: A Javascript file should only be compressed when it is NOT external AND compression is NOT disabled. -
Robert Kärner commented on patch set 6 09/14/21, 07:05
RequestHandler.php:444This was probably the LOC I spent the most time understanding. Original means: If file is external (set and true), return false Or, if file is inline (set and true), return false Or, if disableCompression is (unset or false), return true Let's change the last line: If file is external (set and true), return false Or, if file is inline (set and true), return false Or, if disableCompression is (set and true), return false Now, let's inverse it using boolean algebra !(a || b) = !a && !b: If file is not external (unset or false) And, if file is not inline (unset or false) And, if disableCompression is (unset or false) Return true Let's check for reasonableness: Only compress a CSS file, if it's not external, not inline and compression is not disabled (= compression is enabled) Sounds good! Did I make a mistake? -
Oli Bartsch commented on patch set 6 CR -1 09/14/21, 09:17
RequestHandler.php:446We should fall back to the expected type of addCssFile(). In this case string. This way it will be much easier to introduce strict typing to those functions later. This affects all of those places in this patch. -
Robert Kärner commented on patch set 6 09/14/21, 09:23
RequestHandler.php:446ReplyAck
-
Robert Kärner uploaded patch set 7 09/14/21, 09:32
-
core-ci voted on patch set 7 V +1 09/14/21, 09:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16692
-
Oliver Klee voted on patch set 7 CR +1 09/14/21, 11:14
-
Georg Ringer uploaded patch set 8 09/15/21, 05:46
-
core-ci voted on patch set 8 V +1 09/15/21, 06:00 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16731
-
Georg Ringer uploaded patch set 9 09/15/21, 07:36
-
Jochen Roth commented on patch set 9 09/15/21, 07:46
ContentObjectRenderer.php:3197Maybe set the fallback value to `false` for consistency? -
core-ci voted on patch set 9 V +1 09/15/21, 07:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16733
-
Georg Ringer uploaded patch set 10 09/15/21, 07:58
-
Jochen Roth commented on patch set 9 09/15/21, 07:58
DebugUtility.php:160See https://review.typo3.org/c/Packages/TYPO3.CMS/+/71079/ Seems to fix the same issue. -
core-ci voted on patch set 10 V +1 09/15/21, 08:11 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16735
-
Oliver Klee voted on patch set 10 CR +1 09/15/21, 09:05
-
Jochen Roth uploaded patch set 11 09/15/21, 14:12
-
Oliver Klee voted on patch set 11 CR +1 09/15/21, 14:21
-
core-ci voted on patch set 11 V +1 09/15/21, 14:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16743
-
Jochen Roth uploaded patch set 12 09/16/21, 11:04
-
core-ci voted on patch set 12 V +1 09/16/21, 11:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16793
-
Christian Kuhn voted on patch set 12 V +1 CR +1 09/16/21, 11:18
-
Oli Bartsch commented on patch set 12 CR -1 09/16/21, 22:22
ContentObjectRenderer.php:3189Should also be checkedContentObjectRenderer.php:3189superfluousAbstractMenuContentObject.php:998Should also be checked as in L:980AbstractMenuContentObject.php:998Should be FALSERequestHandler.php:450Would use FALSE here. Makes the intention clear.RequestHandler.php:534Should be a string fallbackRequestHandler.php:659ReplyDone -
Oli Bartsch uploaded patch set 13 09/16/21, 22:26
-
Oli Bartsch commented on patch set 13 V +1 CR +1 09/16/21, 22:32
DebugUtility.php:160ReplyDoneContentObjectRenderer.php:3189ReplyDoneContentObjectRenderer.php:3189ReplyDoneContentObjectRenderer.php:3197ReplyDoneAbstractMenuContentObject.php:998ReplyDoneAbstractMenuContentObject.php:998ReplyDoneRequestHandler.php:450ReplyDoneRequestHandler.php:534ReplyDone -
core-ci voted on patch set 13 V +1 09/16/21, 22:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16835
-
Christian Kuhn voted on patch set 13 V +1 CR +1 09/16/21, 22:49
-
Oli Bartsch voted on patch set 13 V +2 CR +2 09/17/21, 00:11
-
Oli Bartsch merged patch set 14 09/17/21, 00:11
RequestHandler.php:659