Review main Merged

70870[FEATURE] Introduce ModifyClearCacheActionsEvent

Oli Bartsch CR +2 V +2 Normal +180 −0 updated 09/03/21, 14:03

Commit message

A new PSR-14 based event "ModifyClearCacheActionsEvent"
is introduced in favour of the existing
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['additionalBackendItems']['cacheActions']
hook, which is now marked as deprecated, along with
its interface "ClearCacheActionsHookInterface".

The new event features the same functionality as
the hook. Additionally a new convenience method
`add` is available for the class properties, allowing
extension authors to add their custom actions more
easily. This might be the most common use case for
using this event.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1522

  1. Oli Bartsch uploaded patch set 1 09/02/21, 14:45

  2. Oli Bartsch uploaded patch set 2 09/02/21, 14:48

  3. Oli Bartsch uploaded patch set 3 09/02/21, 15:01

  4. core-ci voted on patch set 1 V -1 09/02/21, 15:13 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16092

  5. core-ci voted on patch set 2 V -1 09/02/21, 15:26 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16094

  6. core-ci voted on patch set 3 V +1 09/02/21, 15:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16101

  7. Oli Bartsch uploaded patch set 4 09/02/21, 15:48

  8. core-ci voted on patch set 4 V +1 09/02/21, 16:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16108

  9. Oli Bartsch uploaded patch set 5 09/02/21, 20:57

  10. core-ci voted on patch set 5 V +1 09/02/21, 21:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16136

  11. Benni Mack commented on patch set 5 09/03/21, 09:22

    ModifyClearCacheActionsEvent.php:49

    the naming "optionValues" stinks. It's named in a bad way in the toolbar item, and I'm in favor of naming it "cacheActionIdentifier" - making it "setCacheActionIdentifier" and "getCacheActionIdentifiers"
  12. Oli Bartsch uploaded patch set 6 09/03/21, 11:49

  13. Oli Bartsch commented on patch set 6 09/03/21, 11:50

    ModifyClearCacheActionsEvent.php:49 Reply

    Done
  14. core-ci voted on patch set 6 V +1 09/03/21, 12:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16172

  15. Oli Bartsch uploaded patch set 7 09/03/21, 12:36

  16. core-ci voted on patch set 7 V +1 09/03/21, 12:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16176

  17. Nikita Hovratov voted on patch set 7 V +1 CR +1 09/03/21, 13:04

  18. Benni Mack voted on patch set 7 V +1 CR +1 09/03/21, 13:25

  19. Jochen Roth voted on patch set 7 V +1 CR +1 09/03/21, 13:32

  20. Benni Mack voted on patch set 7 V +2 CR +2 09/03/21, 13:32

  21. Benni Mack merged patch set 8 09/03/21, 13:32

  22. Benjamin Franzke commented on patch set 8 09/03/21, 14:03

    ClearCacheToolbarItem.php:102 Unresolved

    Small nitpick, would love if we avoid getContainer() whenever possible and use injection instead. Was too late with pushing it, therefore here as separate patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70883