Review main Merged

70871[BUGFIX] Add fallback for "task_group" in SchedulerModuleController

Jochen Roth CR +2 V +2 Easy +7 −1 updated 09/06/21, 14:03

Commit message

When creating a new task using PHP8 a undefined key warning
is thrown.

To fix this issue a fallback for "task_group" has been added.
Also extended createASchedulerTask test to check for
expected output in case nom settings (defaults) are given.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Jochen Roth uploaded patch set 1 09/02/21, 16:23

  2. core-ci voted on patch set 1 V -1 09/02/21, 16:38 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16111

  3. Jochen Roth uploaded patch set 2 09/02/21, 16:56

  4. core-ci voted on patch set 2 V +1 09/02/21, 17:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16116

  5. Wouter Wolters voted on patch set 2 CR +1 09/02/21, 18:20

  6. Benni Mack voted on patch set 2 V +1 CR +1 09/02/21, 21:14

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 09/06/21, 14:03

  8. Christian Kuhn merged patch set 3 09/06/21, 14:03