Review main Merged

70872[TASK] Add support for class-string annotation and provide meta file

Andreas Kienast CR +2 V +2 Normal +116 −65 updated 09/06/21, 07:21

Commit message

PhpStorm has basic support for generics since version 2021.2 which comes
in handy as since the same version the "Dynamic Return Type" plugin is broken.

Providing the class-string annotation and a proper return generic
supersedes this and recovers the built-in autocompletion.

To have the same effect for both, 3rd party code not being under our
control or methods having complex returns based on their input, a
`.phpstorm.meta.php` file is provided extending PhpStorms code awareness
capabilities.
Tons of kudos to Alexander Schnitzler providing a boilerplate
configuration here:
https://github.com/alexanderschnitzler/phpstorm.meta.php-typo3

For more information about capability extension consult
https://www.jetbrains.com/help/phpstorm/ide-advanced-metadata.html

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1317

  1. Andreas Kienast uploaded patch set 1 09/02/21, 16:37

  2. Andreas Kienast uploaded patch set 2 09/02/21, 16:50

  3. Stephan Großberndt updated the commit message in patch set 3 09/02/21, 16:52

  4. core-ci voted on patch set 1 V -1 09/02/21, 16:55 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16113

  5. core-ci voted on patch set 2 V -1 09/02/21, 17:11 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16114

  6. core-ci voted on patch set 3 V +1 09/02/21, 17:11 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16115

  7. Oliver Hader voted on patch set 3 CR +1 09/02/21, 18:16

  8. Wouter Wolters voted on patch set 3 CR +1 09/02/21, 18:19

  9. Markus Klein commented on patch set 3 CR +1 09/02/21, 19:11

    😘
  10. Stefan Bürk commented on patch set 3 V +1 CR +1 09/04/21, 15:10

    Tested several invokations and worked flawlessly in several constellations. Thx very much 4 this patch ;)
  11. Andreas Kienast voted on patch set 3 V +2 CR +2 09/04/21, 15:11

  12. Andreas Kienast uploaded patch set 4 09/04/21, 15:34

  13. core-ci voted on patch set 4 V +1 09/04/21, 15:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16262

  14. Stefan Bürk voted on patch set 4 V +1 CR +1 09/04/21, 15:56

  15. Andreas Kienast voted on patch set 4 V +2 CR +2 09/04/21, 15:58

  16. Andreas Kienast merged patch set 5 09/04/21, 15:58

  17. Oliver Hader voted on patch set 5 CR +1 09/06/21, 07:21