Review main Merged

70874[FEATURE] Introduce AfterFileCommandProcessedEvent

Oli Bartsch CR +2 V +2 Normal +199 −10 updated 09/03/21, 20:08

Commit message

A new PSR-14 based event "AfterFileCommandProcessedEvent"
is introduced in favour of the existing
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_extfilefunc.php']['processData']
hook, which is now marked as deprecated, along with
its interface "ExtendedFileUtilityProcessDataHookInterface".

The new event features the same data, however
the way they can be accessed is improved.

The previous `$action` and `$cmdArr` arguments
are now available within the `getCommand()` method,
while the action is the array key and the command
data ($cmdArr) is the value. This is more in line
with the actual request.

The hooks `$result` argument always contained all
results of previous operations, making it unnecessary
complicated to find out the actual result for the
current operation. This is now resolved. The new
`getResult()` method only returns the result for
the currently executed operation.

Finally the "getConflictMode()" method just returns
the conflict mode, used for the current operation.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1114

  1. Oli Bartsch uploaded patch set 1 09/02/21, 20:04

  2. core-ci voted on patch set 1 V -1 09/02/21, 20:23 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16127

  3. Oli Bartsch uploaded patch set 2 09/02/21, 20:56

  4. core-ci voted on patch set 2 V +1 09/02/21, 21:10 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16135

  5. Benni Mack commented on patch set 2 09/02/21, 21:12

    AfterFileCommandProcessedEvent.php:18

    please move this to "TYPO3\CMS\Core\Resource\Event" or "TYPO3\CMS\Core\Resource"
  6. Oli Bartsch uploaded patch set 3 09/02/21, 22:25

  7. Oli Bartsch commented on patch set 3 09/02/21, 22:25

    AfterFileCommandProcessedEvent.php:18 Reply

    Done
  8. core-ci voted on patch set 3 V +1 09/02/21, 22:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16145

  9. Benni Mack voted on patch set 3 V +1 CR +1 09/03/21, 06:58

  10. Jochen Roth voted on patch set 3 V +1 CR +1 09/03/21, 12:29

  11. Oli Bartsch voted on patch set 3 V +2 CR +2 09/03/21, 12:34

  12. Oli Bartsch merged patch set 4 09/03/21, 12:35

  13. Nikita Hovratov commented on patch set 4 09/03/21, 12:38

    Feature-95089-NewPSR-14AfterFileCommandProcessedEvent.rst:19

    typo in performed
  14. Oli Bartsch commented on patch set 4 09/03/21, 20:08

    Feature-95089-NewPSR-14AfterFileCommandProcessedEvent.rst:19 Reply Unresolved

    Thanks, could be fixed will moving RST files to the sprint release directory.