70875[BUGFIX] Add fallback for array keys in Export/ImportExport
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
Review log 78
-
Jochen Roth uploaded patch set 1 09/02/21, 20:17
-
core-ci voted on patch set 1 V +1 09/02/21, 20:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16131
-
Benni Mack voted on patch set 1 V +1 CR +1 09/03/21, 11:41
-
Oli Bartsch commented on patch set 1 09/03/21, 12:34
Export.php:959UnresolvedIf this can be null, should we change the logic here since L:952 uses this for generating the ID, which will then be duplicated in case it's not defined for multiple elements.ImportExport.php:894Unresolved'mode' not longer needed? -
Alexander Nitsche commented on patch set 1 09/03/21, 20:14
Unresolved
Fyi: This patch has the same scope as that patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70741. -
Jochen Roth commented on patch set 1 09/06/21, 08:03
Added php8 related code the this patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70741 The ac test part has it's own patch now: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70912 -
Jochen Roth commented on patch set 1 09/06/21, 08:04
Reply
Therefore i'll abandon this one. -
Jochen Roth abandoned the change 09/06/21, 08:05
Changes are done in another patch, see comments.
Export.php:723Unresolved