Review main Merged

70879[TASK] Add loading indicator to "Manage Reference Index"

Jochen Roth CR +2 V +2 Normal +65 −3 updated 09/07/21, 09:26

Commit message

Processing of "Manage Reference Index" actions
(check/update) can take quite some time.

To give the user better feedback of the current state
a loading indicator has been added and buttons
are disabled during processing.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1625

  1. Jochen Roth uploaded patch set 1 09/03/21, 09:12

  2. Jochen Roth uploaded patch set 2 09/03/21, 09:17

  3. core-ci voted on patch set 1 V +1 09/03/21, 09:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16158

  4. core-ci voted on patch set 2 V +1 09/03/21, 09:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16159

  5. Oli Bartsch commented on patch set 2 09/03/21, 12:28

    Progress.ts:20

    Could we please use a more speaking name?

    Progress.ts:29

    We may use a web component or at least a t3js class. Otherwise this is IMO to generic.

    Progress.ts:33

    buttons.forEach in buttons.forEach? Can we just use a regular event and delegate it to the buttons?
  6. Jochen Roth uploaded patch set 3 09/03/21, 15:53

  7. core-ci voted on patch set 3 V -1 09/03/21, 16:10 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16205

  8. Jochen Roth uploaded patch set 4 09/03/21, 18:20

  9. core-ci voted on patch set 4 V +1 09/03/21, 18:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16211

  10. Jochen Roth uploaded patch set 5 09/06/21, 08:34

  11. Jochen Roth uploaded patch set 6 09/06/21, 08:43

  12. core-ci voted on patch set 5 V +1 09/06/21, 08:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16309

  13. core-ci voted on patch set 6 V +1 09/06/21, 09:00 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16310

  14. Jochen Roth commented on patch set 6 09/06/21, 09:53

    Progress.ts:20 Reply

    Done

    Progress.ts:29 Reply Unresolved

    Now using a t3js class.

    Progress.ts:33 Reply

    Ack
  15. Christian Kuhn commented on patch set 6 09/06/21, 13:53

    in general: fine with me. a true ajax based update thingie showing what exactly is happening, would be great, but this patch is a good start. compare with cli refindex updater, which shows a cool progress.
  16. Jochen Roth uploaded patch set 7 09/06/21, 14:53

  17. core-ci voted on patch set 7 V +1 09/06/21, 15:10 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16331

  18. Oli Bartsch commented on patch set 7 CR -1 09/06/21, 17:41

    On it
  19. Oli Bartsch uploaded patch set 8 09/06/21, 18:10

  20. core-ci voted on patch set 8 V -1 09/06/21, 18:29 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16347

  21. core-ci voted on patch set 8 V +1 09/06/21, 19:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16347

  22. Andreas Kienast voted on patch set 8 V +1 CR +1 09/06/21, 20:01

  23. Jochen Roth voted on patch set 8 V +1 CR +1 09/07/21, 07:15

  24. Oli Bartsch voted on patch set 8 V +2 CR +2 09/07/21, 09:26

  25. Oli Bartsch merged patch set 9 09/07/21, 09:26