70879[TASK] Add loading indicator to "Manage Reference Index"
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Andreas Kienast +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 4
- Build/Sources/TypeScript/lowlevel/Resources/Public/TypeScript/ReferenceIndex.tsnew+44 −0
- typo3/sysext/lowlevel/Classes/Controller/DatabaseIntegrityController.php+1 −0
- typo3/sysext/lowlevel/Resources/Private/Templates/Backend/ReferenceIndex.html+7 −3
- typo3/sysext/lowlevel/Resources/Public/JavaScript/ReferenceIndex.jsnew+13 −0
Review log 1625
-
Jochen Roth uploaded patch set 1 09/03/21, 09:12
-
Jochen Roth uploaded patch set 2 09/03/21, 09:17
-
core-ci voted on patch set 1 V +1 09/03/21, 09:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16158
-
core-ci voted on patch set 2 V +1 09/03/21, 09:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16159
-
Oli Bartsch commented on patch set 2 09/03/21, 12:28
Progress.ts:29We may use a web component or at least a t3js class. Otherwise this is IMO to generic.Progress.ts:33buttons.forEach in buttons.forEach? Can we just use a regular event and delegate it to the buttons? -
Jochen Roth uploaded patch set 3 09/03/21, 15:53
-
core-ci voted on patch set 3 V -1 09/03/21, 16:10 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16205
-
Jochen Roth uploaded patch set 4 09/03/21, 18:20
-
core-ci voted on patch set 4 V +1 09/03/21, 18:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16211
-
Jochen Roth uploaded patch set 5 09/06/21, 08:34
-
Jochen Roth uploaded patch set 6 09/06/21, 08:43
-
core-ci voted on patch set 5 V +1 09/06/21, 08:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16309
-
core-ci voted on patch set 6 V +1 09/06/21, 09:00 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16310
-
Jochen Roth commented on patch set 6 09/06/21, 09:53
Progress.ts:20ReplyDoneProgress.ts:29Reply UnresolvedNow using a t3js class.Progress.ts:33ReplyAck -
Christian Kuhn commented on patch set 6 09/06/21, 13:53
in general: fine with me. a true ajax based update thingie showing what exactly is happening, would be great, but this patch is a good start. compare with cli refindex updater, which shows a cool progress. -
Jochen Roth uploaded patch set 7 09/06/21, 14:53
-
core-ci voted on patch set 7 V +1 09/06/21, 15:10 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16331
-
Oli Bartsch commented on patch set 7 CR -1 09/06/21, 17:41
On it -
Oli Bartsch uploaded patch set 8 09/06/21, 18:10
-
core-ci voted on patch set 8 V -1 09/06/21, 18:29 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16347
-
core-ci voted on patch set 8 V +1 09/06/21, 19:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16347
-
Andreas Kienast voted on patch set 8 V +1 CR +1 09/06/21, 20:01
-
Jochen Roth voted on patch set 8 V +1 CR +1 09/07/21, 07:15
-
Oli Bartsch voted on patch set 8 V +2 CR +2 09/07/21, 09:26
-
Oli Bartsch merged patch set 9 09/07/21, 09:26
Progress.ts:20