Review main Merged

70881[TASK] LinkResult should have return consistent types when serialized to JSON

Tomek Woldański CR +2 V +2 Easy +13 −6 updated 09/03/21, 11:57

Commit message

Right now some properties returns empty string or null when value is empty. i.e. title (null when empty), target ('' string when "empty").

Patch makes all serialized properties behavior consistent (null on empty string values).

Review

  • Code review CR +2 Done
    • Tymoteusz Motylewski +2
    • Benni Mack +1
  • Verified V +2 Done
    • Tymoteusz Motylewski +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 45

  1. Tomek Woldański uploaded patch set 1 09/03/21, 10:21

  2. core-ci voted on patch set 1 V +1 09/03/21, 10:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16166

  3. Benni Mack voted on patch set 1 V +1 CR +1 09/03/21, 10:56

  4. Tymoteusz Motylewski voted on patch set 1 V +2 CR +2 09/03/21, 11:57

  5. Tymoteusz Motylewski merged patch set 2 09/03/21, 11:57