Review main Merged

70882[TASK] Generate requestId as injectable object

Benjamin Franzke CR +2 V +2 Easy +44 −3 updated 09/04/21, 08:49

Commit message

This is a preparation in order to decouple
LogManager and log attribute in future.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 57

  1. Benjamin Franzke uploaded patch set 1 09/03/21, 12:29

  2. core-ci voted on patch set 1 V -1 09/03/21, 12:51 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16174

  3. core-ci voted on patch set 1 V +1 09/03/21, 13:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16174

  4. Benni Mack voted on patch set 1 V +1 CR +1 09/03/21, 13:26

  5. Oli Bartsch voted on patch set 1 V +1 CR +1 09/04/21, 08:21

  6. Benjamin Franzke voted on patch set 1 V +2 CR +2 09/04/21, 08:49

  7. Benjamin Franzke merged patch set 2 09/04/21, 08:49