Review main Merged

70883[TASK] Avoid GeneralUtility::getContainer() in ClearCacheToolbarItem

Benjamin Franzke CR +2 V +2 Easy +11 −14 updated 09/03/21, 20:36

Commit message

EventDispatcherInterface injection is easy here, therefore lets to
so in order to avoid the discouraged global lookup via GeneralUtility.

Also refactor to inject other dependencies.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Benjamin Franzke uploaded patch set 1 09/03/21, 13:43

  2. Benjamin Franzke uploaded patch set 2 09/03/21, 13:44

  3. core-ci voted on patch set 2 V +1 09/03/21, 13:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16184

  4. Benni Mack voted on patch set 2 V +1 CR +1 09/03/21, 14:07

  5. Oli Bartsch voted on patch set 2 V +2 CR +2 09/03/21, 20:36

  6. Oli Bartsch merged patch set 3 09/03/21, 20:36