70886[TASK] Make some type annotations more specific
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Rick Septer +1
- Wouter Wolters +1
- crell +1
-
Verified V +2 Done
- Oliver Hader +2
- crell +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1317
-
Oliver Klee uploaded patch set 1 09/03/21, 17:02
-
Oliver Klee updated the commit message in patch set 2 09/03/21, 17:03
-
core-ci voted on patch set 1 V -1 09/03/21, 17:21 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16208
-
core-ci voted on patch set 2 V -1 09/03/21, 17:22 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16209
-
Oliver Klee commented on patch set 2 CR -1 09/03/21, 17:25
On it. -
Oliver Klee uploaded patch set 3 09/04/21, 13:51
-
core-ci voted on patch set 3 V +1 09/04/21, 14:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16247
-
Benni Mack voted on patch set 3 CR +1 09/07/21, 06:05
-
Benni Mack updated the commit message in patch set 4 09/07/21, 06:06
-
core-ci voted on patch set 4 V +1 09/07/21, 06:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16365
-
crell commented on patch set 4 V +1 CR +1 09/07/21, 14:28
Such return types are messy and ugly, but well-documented messy and ugly is still an improvement. Endorse. -
Wouter Wolters voted on patch set 4 CR +1 09/07/21, 19:38
-
Rick Septer voted on patch set 4 CR +1 09/08/21, 14:12
-
Oliver Hader voted on patch set 4 CR +1 09/14/21, 11:30
-
Oliver Hader voted on patch set 4 V +2 CR +2 09/14/21, 11:31
-
Oliver Hader merged patch set 5 09/14/21, 11:31
-
Oliver Klee commented on patch set 5 09/14/21, 11:32
Thanks, Olli!