Review main Merged

70887[FEATURE] Introduce PSR-14 events for DatabaseRecordList

Oli Bartsch CR +2 V +2 Hard +791 −16 updated 09/04/21, 07:12

Commit message

Three new PSR-14 based events are introduced in favour
of the existing $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['typo3/class.db_list_extra.inc']['actions']
hook, which is now marked as deprecated, along with
its interface "RecordListHookInterface".

Besides the obvious advantage of using PSR-14 events,
the RecordListHookInterface also required to always
implement all hook methods, even if only one of them
was really used.

The new events feature the same functionality, but
improved and extended. The main subject, e.g. the
record actions or the table header columns, is
therefore equipped with extended CRUD methods,
like adding a new action at a certain position.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 1018

  1. Oli Bartsch uploaded patch set 1 09/03/21, 20:29

  2. Oli Bartsch uploaded patch set 2 09/03/21, 20:30

  3. core-ci voted on patch set 1 V -1 09/03/21, 20:48 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16214

  4. core-ci voted on patch set 2 V -1 09/03/21, 20:48 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16215

  5. Oli Bartsch uploaded patch set 3 09/03/21, 21:02

  6. core-ci voted on patch set 3 V -1 09/03/21, 21:20 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16216

  7. Oli Bartsch uploaded patch set 4 09/03/21, 22:31

  8. core-ci voted on patch set 4 V +1 09/03/21, 22:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16219

  9. Oli Bartsch uploaded patch set 5 09/04/21, 00:45

  10. core-ci voted on patch set 5 V +1 09/04/21, 01:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16220

  11. Oli Bartsch updated the commit message in patch set 6 09/04/21, 01:04

  12. core-ci voted on patch set 6 V +1 09/04/21, 01:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16222

  13. Benjamin Franzke uploaded patch set 7 09/04/21, 04:22

  14. core-ci voted on patch set 7 V -1 09/04/21, 04:43 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16225

  15. Benjamin Franzke uploaded patch set 8 09/04/21, 05:24

  16. core-ci voted on patch set 8 V +1 09/04/21, 05:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16226

  17. Benni Mack voted on patch set 8 V +2 CR +2 09/04/21, 07:12

  18. Benni Mack merged patch set 9 09/04/21, 07:12