Review main Abandoned Breaking

70889[!!!][TASK] Remove "Regular expression" validator from form editor

Björn Jacob CR 0 V 0 Normal +95 −64 updated 02/24/22, 09:49

Commit message

The "Regular expression" validator has been removed form the UI of the
form editor since the form editor should be uncluttered and stripped
from too technical and complex concepts. Regular expressions are
difficult to understand especially for our main target group which are
editors. If an editor provides an invalid regex an exceptions is thrown
in the frontend. This is a no-go and should never be the case.

The validator has only been removed form the UI. If a form definition
contains a regular expression validator, the form editor is still able
to display it and allows changes.

The documentation has been adapted accordingly.

We consider this as a breaking change since the behaviour of the UI
changes.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 22

Show 2 more files

Review log 2436

Show 711 earlier messages
  1. Björn Jacob uploaded patch set 1 09/04/21, 07:16

  2. Björn Jacob uploaded patch set 2 09/04/21, 07:26

  3. waldhacker voted on patch set 2 CR -1 09/04/21, 07:28

  4. core-ci voted on patch set 1 V +1 09/04/21, 07:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16229

  5. core-ci voted on patch set 2 V +1 09/04/21, 07:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16230

  6. waldhacker uploaded patch set 3 09/04/21, 08:04

  7. core-ci voted on patch set 3 V +1 09/04/21, 08:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16231

  8. waldhacker voted on patch set 3 CR -1 09/04/21, 08:23

  9. waldhacker uploaded patch set 4 09/04/21, 09:06

  10. waldhacker updated the commit message in patch set 5 09/04/21, 09:06

  11. core-ci voted on patch set 4 V +1 09/04/21, 09:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16233

  1. core-ci voted on patch set 5 V +1 09/04/21, 09:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16234

  2. Björn Jacob updated the commit message in patch set 6 09/04/21, 10:04

  3. waldhacker voted on patch set 6 V +1 CR +1 09/04/21, 10:09

  4. core-ci voted on patch set 6 V +1 09/04/21, 10:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16235

  5. Oliver Hader commented on patch set 6 CR -1 09/06/21, 09:45

    Some might say this is a breaking change in UI for editors. Thus, I'd rather opt to drop the UI component in TYPO3 v12.0
  6. Benni Mack wrote 11/29/21, 10:09

    Change destination moved from master to main
  7. Benni Mack updated the commit message in patch set 7 11/29/21, 13:27

  8. core-ci voted on patch set 7 V +1 11/29/21, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20030

  9. Benni Mack uploaded patch set 8 12/18/21, 08:15

  10. Benni Mack voted on patch set 8 CR +1 12/18/21, 08:15

  11. core-ci voted on patch set 8 V +1 12/18/21, 08:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21231

  12. Björn Jacob commented on patch set 8 CR -1 02/22/22, 14:27

    Will add a breaking change rst and handle it as breaking.
  13. Elias Häußler uploaded patch set 9 02/23/22, 11:55

  14. core-ci voted on patch set 9 V +1 02/23/22, 12:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24100

  15. Oliver Hader commented on patch set 9 02/23/22, 12:14

    inspector-component.js:1138

    Can you please add a short description, what this part actually does and in which scenario/context? Thx!
  16. Elias Häußler uploaded patch set 10 02/23/22, 15:17

  17. core-ci voted on patch set 10 V +1 02/23/22, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24116

  18. Björn Jacob commented on patch set 10 CR -1 02/23/22, 15:30

    On it. Will add a breaking change rst and mark it as breaking.
  19. Björn Jacob uploaded patch set 11 02/23/22, 15:45

  20. core-ci voted on patch set 11 V -1 02/23/22, 15:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24122

  21. waldhacker uploaded patch set 12 02/23/22, 16:38

  22. waldhacker commented on patch set 12 02/23/22, 16:39

    inspector-component.js:1138 Reply

    Done
  23. core-ci voted on patch set 12 V -1 02/23/22, 16:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24127

  24. Björn Jacob abandoned the change 02/24/22, 08:37

  25. Björn Jacob commented on patch set 12 02/24/22, 09:49

    We decided to abandon this patch. Instead we want to deprecate its usage within the form editor. I have created a new ticket and pushed a new patch.