Review main Merged

70892[TASK] Enable a flaky marked postgres test as it seems to work

Stefan Bürk CR +2 V +2 Easy +0 −2 updated 09/06/21, 13:31

Commit message

A functional test has been disabled for postgres because the test
was flaky (what ever this meant exactly) and has been leading to
occassional test run failure.

Using git bisect the first working commit has been way back before
v11.0.0 release tag

  27c7de8a6e [!!!][TASK] Remove move placeholders #92497

as the commit before has been failing

  64542d624e [TASK] Decouple Dependency logic and domain models in EM

As the patch which has been fixed the related stuff for the flaky
test is not an easy area (or at least I'm not in ) it is really
hard to identify which exactly in that commit has fixed it.

Anyway, as proven through a lot of checkouts sinces this commit and
even current master (run through nightly) passed all green thus
this test is activated again.

Testcommands:
(on different versions/commits + patch | as available )

Build/Scripts/runTests.sh -s functional -d postgres \
typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/\
Modify/ActionTest.php

Build/Scripts/runTests.sh -s functional -d postgres -k 9.6 \
typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/\
Modify/ActionTest.php

Build/Scripts/runTests.sh -s functional -d postgres -k 10 \
typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/\
Modify/ActionTest.php

Build/Scripts/runTests.sh -s functional -d postgres -k 11 \
typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/\
Modify/ActionTest.php

Build/Scripts/runTests.sh -s functional -d postgres -k 12 \
typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/\
Modify/ActionTest.php

Build/Scripts/runTests.sh -s functional -d postgres -k 13 \
typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/\
Modify/ActionTest.php

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1623

  1. Stefan Bürk uploaded patch set 1 09/04/21, 12:09

  2. Stefan Bürk voted on patch set 1 CR -1 09/04/21, 12:10

  3. core-ci voted on patch set 1 V -1 09/04/21, 12:35 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16240

  4. core-ci voted on patch set 1 V +1 09/04/21, 12:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16240

  5. Stefan Bürk wrote 09/04/21, 15:58

    Removed Code-Review-1 by Stefan Bürk <stefan@buerk.tech>
  6. Stefan Bürk rebased onto patch set 2 09/04/21, 15:58

  7. core-ci voted on patch set 2 V +1 09/04/21, 16:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16266

  8. core-ci commented on patch set 2 09/04/21, 17:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16267

  9. Stefan Bürk voted on patch set 2 CR -1 09/04/21, 17:22

  10. Stefan Bürk updated the commit message in patch set 3 09/04/21, 17:50

  11. Stefan Bürk voted on patch set 3 CR -1 09/04/21, 17:50

  12. core-ci voted on patch set 3 V +1 09/04/21, 18:06 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16270

  13. Oliver Klee commented on patch set 3 09/05/21, 07:50

    Note for the next version: flacky -> flaky
  14. Stefan Bürk updated the commit message in patch set 4 09/05/21, 10:30

  15. Stefan Bürk commented on patch set 4 09/05/21, 10:31

    Reply

    Done
  16. Stefan Bürk wrote 09/05/21, 10:34

    Topic set to Postgres Tests
  17. core-ci voted on patch set 4 V +1 09/05/21, 10:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16285

  18. Christian Kuhn uploaded patch set 5 09/06/21, 12:51

  19. Christian Kuhn commented on patch set 5 V +1 CR +1 09/06/21, 12:52

    thanks for you excessive work on this!
  20. core-ci voted on patch set 5 V +1 09/06/21, 13:11 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16320

  21. Jochen Roth voted on patch set 5 V +1 CR +1 09/06/21, 13:31

  22. Christian Kuhn voted on patch set 5 V +2 CR +2 09/06/21, 13:31

  23. Christian Kuhn merged patch set 6 09/06/21, 13:31