Review main Merged

70894[BUGFIX] Require symfony/polyfill-php80 at least in version 1.16.0

Anja Leichsenring CR +2 V +2 Easy +3 −1 updated 09/04/21, 15:00

Commit message

Used commands:

    composer require symfony/polyfill-php80:^1.16
    composer require symfony/polyfill-php80:^1.16 \
        -d typo3/sysext/form --no-update

This fixes a composer min acceptance test failure, that chokes on the
function str_ends_with() not being available in a PHP 7.4 environment.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 58

  1. Anja Leichsenring uploaded patch set 1 09/04/21, 13:58

  2. core-ci voted on patch set 1 V +1 09/04/21, 14:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16248

  3. Andreas Kienast uploaded patch set 2 09/04/21, 14:21

  4. core-ci voted on patch set 2 V +1 09/04/21, 14:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16253

  5. core-ci commented on patch set 1 09/04/21, 14:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16249

  6. Stefan Bürk commented on patch set 2 V +1 CR +1 09/04/21, 14:59

    Manual nightly fully passed
  7. Andreas Kienast voted on patch set 2 V +2 CR +2 09/04/21, 15:00

  8. Andreas Kienast merged patch set 3 09/04/21, 15:00