70896[BUGFIX] Update feature toggles state at once
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Anja Leichsenring +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Anja Leichsenring +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1723
-
TYPO3com uploaded patch set 1 09/05/21, 10:13
-
core-ci voted on patch set 1 V -1 09/05/21, 10:36 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16284
-
Benni Mack updated the commit message in patch set 2 10/13/21, 12:37
-
Georg Ringer commented on patch set 2 CR -1 10/13/21, 12:39
-
core-ci voted on patch set 2 V -1 10/13/21, 13:00 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18043
-
Oli Bartsch commented on patch set 2 10/13/21, 14:52
SettingsController.php:555ReplyI'm already on it. Sorry, should have commented. -
Oli Bartsch uploaded patch set 3 10/13/21, 15:23
-
Oli Bartsch updated the commit message in patch set 4 10/13/21, 15:24
-
Oli Bartsch commented on patch set 4 V +1 CR +1 10/13/21, 15:25
SettingsController.php:555ReplyDone -
core-ci voted on patch set 4 V -1 10/13/21, 15:46 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18057
-
core-ci voted on patch set 3 V -1 10/13/21, 15:47 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18055
-
Jochen Roth uploaded patch set 5 10/13/21, 17:17
-
core-ci voted on patch set 5 V +1 10/13/21, 17:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18064
-
Oli Bartsch voted on patch set 5 V +1 CR +1 10/13/21, 18:24
-
Christian Kuhn commented on patch set 5 CR -1 10/13/21, 18:27
I hope it's ok to -1 this from me for no apparent reason ;) I'm interested in this change and will review soon ... this flood of changes when toggling features nagged me for quite a while already ... -
Simon Schaufelberger commented on patch set 5 10/14/21, 11:23
SettingsController.php:542Should this message not come from a locallang file so that it can be translated? -
Christian Kuhn commented on patch set 5 10/14/21, 13:47
SettingsController.php:542Replyinstall tool is not localized -
Simon Schaufelberger commented on patch set 5 10/14/21, 15:22
SettingsController.php:542Replyok -
Simon Schaufelberger wrote 10/19/21, 16:20
Removed cc Simon Schaufelberger. -
Anja Leichsenring commented on patch set 5 V +1 CR +1 11/04/21, 12:02
I'd say it works nicely, and @lolli you likely want to reconsider your -1 for no apparant reasons ;) The issue you have in mind is unrelated, but the patch works as advertised. -
Christian Kuhn voted on patch set 5 V +1 CR +1 11/04/21, 14:18
-
Christian Kuhn voted on patch set 5 V +2 CR +2 11/04/21, 14:18
-
Christian Kuhn merged patch set 6 11/04/21, 14:18
SettingsController.php:555