Review main Merged

70896[BUGFIX] Update feature toggles state at once

TYPO3com CR +2 V +2 Normal +35 −18 updated 11/04/21, 14:18

Commit message

When updating feature toggles, the corresponding method
iterates over all feature toggles and checks if those
state changed. If so, previously each changed toggle
state was saved individually, leading to problems
with file caches.

This is now fixed by storing the toggles to be changed
in an intermediate array which is then executed a single
time, only modifying the LocalConfiguration file once.

Additonally, the flash message is improved.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1723

  1. TYPO3com uploaded patch set 1 09/05/21, 10:13

  2. core-ci voted on patch set 1 V -1 09/05/21, 10:36 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16284

  3. Benni Mack updated the commit message in patch set 2 10/13/21, 12:37

  4. Georg Ringer commented on patch set 2 CR -1 10/13/21, 12:39

    SettingsController.php:555

    can you replace that with $message
  5. core-ci voted on patch set 2 V -1 10/13/21, 13:00 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18043

  6. Oli Bartsch commented on patch set 2 10/13/21, 14:52

    SettingsController.php:555 Reply

    I'm already on it. Sorry, should have commented.
  7. Oli Bartsch uploaded patch set 3 10/13/21, 15:23

  8. Oli Bartsch updated the commit message in patch set 4 10/13/21, 15:24

  9. Oli Bartsch commented on patch set 4 V +1 CR +1 10/13/21, 15:25

    SettingsController.php:555 Reply

    Done
  10. core-ci voted on patch set 4 V -1 10/13/21, 15:46 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18057

  11. core-ci voted on patch set 3 V -1 10/13/21, 15:47 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18055

  12. Jochen Roth uploaded patch set 5 10/13/21, 17:17

  13. core-ci voted on patch set 5 V +1 10/13/21, 17:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18064

  14. Oli Bartsch voted on patch set 5 V +1 CR +1 10/13/21, 18:24

  15. Christian Kuhn commented on patch set 5 CR -1 10/13/21, 18:27

    I hope it's ok to -1 this from me for no apparent reason ;) I'm interested in this change and will review soon ... this flood of changes when toggling features nagged me for quite a while already ...
  16. Simon Schaufelberger commented on patch set 5 10/14/21, 11:23

    SettingsController.php:542

    Should this message not come from a locallang file so that it can be translated?
  17. Christian Kuhn commented on patch set 5 10/14/21, 13:47

    SettingsController.php:542 Reply

    install tool is not localized
  18. Simon Schaufelberger commented on patch set 5 10/14/21, 15:22

    SettingsController.php:542 Reply

    ok
  19. Simon Schaufelberger wrote 10/19/21, 16:20

    Removed cc Simon Schaufelberger.
  20. Anja Leichsenring commented on patch set 5 V +1 CR +1 11/04/21, 12:02

    I'd say it works nicely, and @lolli you likely want to reconsider your -1 for no apparant reasons ;) The issue you have in mind is unrelated, but the patch works as advertised.
  21. Christian Kuhn voted on patch set 5 V +1 CR +1 11/04/21, 14:18

  22. Christian Kuhn voted on patch set 5 V +2 CR +2 11/04/21, 14:18

  23. Christian Kuhn merged patch set 6 11/04/21, 14:18