Review main Merged

70897[TASK] Enable postgres test after fixing setUpFrontendRootPage

Stefan Bürk CR +2 V +2 Easy +0 −2 updated 09/21/21, 09:30

Commit message

A functional test has been disabled for postgres execution due
duplicate key issues using `setupFrontendRootPage` in functional
testcases.

As setUpFrontendRootPage has been fixed in the testing framework,
this test is enabled again.

Commands to test:

$ Build/Scripts/runTests.sh -s functional -p 7.4 -d postgres -k 9.6 \
typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php

$ Build/Scripts/runTests.sh -s functional -p 7.4 -d postgres -k 10 \
typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php

$ Build/Scripts/runTests.sh -s functional -p 7.4 -d postgres -k 11 \
typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php

$ Build/Scripts/runTests.sh -s functional -p 7.4 -d postgres -k 12 \
typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php

$ Build/Scripts/runTests.sh -s functional -p 7.4 -d postgres -k 13 \
typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php

$ Build/Scripts/runTests.sh -s functional -p 8.0 -d postgres -k 9.6 \
typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php

$ Build/Scripts/runTests.sh -s functional -p 8.0 -d postgres -k 10 \
typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php

$ Build/Scripts/runTests.sh -s functional -p 8.0 -d postgres -k 11 \
typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php

$ Build/Scripts/runTests.sh -s functional -p 8.0 -d postgres -k 12 \
typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php

$ Build/Scripts/runTests.sh -s functional -p 8.0 -d postgres -k 13 \
typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1015

  1. Stefan Bürk uploaded patch set 1 09/05/21, 11:57

  2. core-ci voted on patch set 1 V -1 09/05/21, 12:13 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16289

  3. Stefan Bürk uploaded patch set 2 09/05/21, 12:23

  4. core-ci voted on patch set 2 V -1 09/05/21, 12:37 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16290

  5. Stefan Bürk wrote 09/05/21, 12:50

    Topic set to Postgres Tests
  6. Stefan Bürk rebased onto patch set 3 09/12/21, 15:48

  7. core-ci voted on patch set 3 V -1 09/12/21, 15:58 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16625

  8. Stefan Bürk updated the commit message in patch set 4 09/12/21, 16:07

  9. Stefan Bürk marked it ready for review 09/12/21, 16:16

  10. core-ci voted on patch set 4 V -1 09/12/21, 16:20 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16627

  11. Stefan Bürk rebased onto patch set 5 09/20/21, 20:57

  12. core-ci voted on patch set 5 V +1 09/20/21, 21:11 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16954

  13. Christian Kuhn voted on patch set 5 V +1 CR +1 09/21/21, 09:20

  14. Benni Mack voted on patch set 5 V +2 CR +2 09/21/21, 09:30

  15. Benni Mack merged patch set 6 09/21/21, 09:30