Review main Merged

70898[TASK] Improve exception message for failed url generation

Georg Ringer CR +2 V +2 Easy +3 −3 updated 10/19/21, 20:24

Commit message

Changing the exception message can help developers to find the issue
faster. The previous message "The page 123 had no proper connection to a
site, no link could be built." is not always correct because there might
be exceptions raised when the slug field is empty.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1721

  1. Georg Ringer uploaded patch set 1 09/06/21, 06:30

  2. Georg Ringer commented on patch set 1 09/06/21, 06:31

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 09/06/21, 06:46 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16299

  4. Georg Ringer uploaded patch set 2 09/06/21, 06:50

  5. core-ci voted on patch set 2 V +1 09/06/21, 07:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16302

  6. Markus Klein voted on patch set 2 V +1 CR +1 09/06/21, 08:25

  7. Josef Glatz voted on patch set 2 CR +1 09/06/21, 09:16

  8. Helmut Hummel commented on patch set 2 CR -1 09/06/21, 11:07

    What I would do instead, is pass the parent exception as argument to the newly thrown one, because then even the TYPO3 exception renderer can show the trace of the nested exception as well, not only its message
  9. Helmut Hummel commented on patch set 2 09/06/21, 11:08

    BackendUtility.php:2176

    Pass $e as third argument here instead

    PreviewController.php:167

    Pass $e as third argument here instead

    PreviewUriBuilder.php:98

    Pass $e as third argument here instead
  10. Georg Ringer uploaded patch set 3 10/19/21, 18:55

  11. core-ci voted on patch set 3 V +1 10/19/21, 19:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18339

  12. Georg Ringer commented on patch set 3 10/19/21, 19:25

    BackendUtility.php:2176 Reply

    Done

    PreviewController.php:167 Reply

    Done

    PreviewUriBuilder.php:98 Reply

    Done
  13. Christian Kuhn voted on patch set 3 V +1 CR +1 10/19/21, 20:05

  14. Stefan Bürk voted on patch set 3 V +1 CR +1 10/19/21, 20:07

  15. Wouter Wolters commented on patch set 3 10/19/21, 20:08

    might also be exceptions?
  16. Christian Kuhn updated the commit message in patch set 4 10/19/21, 20:12

  17. Wouter Wolters voted on patch set 4 V +1 CR +1 10/19/21, 20:13

  18. Stefan Bürk voted on patch set 4 V +1 CR +1 10/19/21, 20:13

  19. Christian Kuhn commented on patch set 4 V +2 CR +2 10/19/21, 20:15

    Reply

    Done
  20. core-ci voted on patch set 4 V +1 10/19/21, 20:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18343

  21. Christian Kuhn merged patch set 5 10/19/21, 20:24