70898[TASK] Improve exception message for failed url generation
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Wouter Wolters +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Wouter Wolters +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1721
-
Georg Ringer uploaded patch set 1 09/06/21, 06:30
-
Georg Ringer commented on patch set 1 09/06/21, 06:31
This change is ready for review. -
core-ci voted on patch set 1 V -1 09/06/21, 06:46 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16299
-
Georg Ringer uploaded patch set 2 09/06/21, 06:50
-
core-ci voted on patch set 2 V +1 09/06/21, 07:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16302
-
Markus Klein voted on patch set 2 V +1 CR +1 09/06/21, 08:25
-
Josef Glatz voted on patch set 2 CR +1 09/06/21, 09:16
-
Helmut Hummel commented on patch set 2 CR -1 09/06/21, 11:07
What I would do instead, is pass the parent exception as argument to the newly thrown one, because then even the TYPO3 exception renderer can show the trace of the nested exception as well, not only its message -
Helmut Hummel commented on patch set 2 09/06/21, 11:08
BackendUtility.php:2176Pass $e as third argument here insteadPreviewController.php:167Pass $e as third argument here insteadPreviewUriBuilder.php:98Pass $e as third argument here instead -
Georg Ringer uploaded patch set 3 10/19/21, 18:55
-
core-ci voted on patch set 3 V +1 10/19/21, 19:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18339
-
Georg Ringer commented on patch set 3 10/19/21, 19:25
BackendUtility.php:2176ReplyDonePreviewController.php:167ReplyDonePreviewUriBuilder.php:98ReplyDone -
Christian Kuhn voted on patch set 3 V +1 CR +1 10/19/21, 20:05
-
Stefan Bürk voted on patch set 3 V +1 CR +1 10/19/21, 20:07
-
Wouter Wolters commented on patch set 3 10/19/21, 20:08
might also be exceptions? -
Christian Kuhn updated the commit message in patch set 4 10/19/21, 20:12
-
Wouter Wolters voted on patch set 4 V +1 CR +1 10/19/21, 20:13
-
Stefan Bürk voted on patch set 4 V +1 CR +1 10/19/21, 20:13
-
Christian Kuhn commented on patch set 4 V +2 CR +2 10/19/21, 20:15
Reply
Done -
core-ci voted on patch set 4 V +1 10/19/21, 20:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18343
-
Christian Kuhn merged patch set 5 10/19/21, 20:24