Review main Merged

70912[TASK] Stabilize ImportCest.php acceptance test

Jochen Roth CR +2 V +2 Easy +4 −2 updated 09/07/21, 05:56

Commit message

Sometimes during testing the imported page
404 can't be found.

The import acceptance test has been improved
using the given "getPageXPathByPageName" method
so it will hopefully behave in the future.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Jochen Roth uploaded patch set 1 09/06/21, 07:59

  2. core-ci voted on patch set 1 V +1 09/06/21, 08:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16307

  3. Christian Kuhn updated the commit message in patch set 2 09/06/21, 13:41

  4. Christian Kuhn voted on patch set 2 V +1 CR +1 09/06/21, 13:41

  5. core-ci voted on patch set 2 V +1 09/06/21, 14:00 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16326

  6. Wouter Wolters voted on patch set 2 V +1 CR +1 09/06/21, 17:42

  7. Benni Mack voted on patch set 2 V +2 CR +2 09/07/21, 05:56

  8. Benni Mack merged patch set 3 09/07/21, 05:56