70914[TASK] Avoid using hook for context menu settings
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 10
- Build/Sources/TypeScript/filelist/Resources/Public/TypeScript/ContextMenuActions.ts2+10 −6
- Build/Sources/TypeScript/impexp/Resources/Public/TypeScript/ContextMenuActions.ts+7 −5
- typo3/sysext/filelist/Classes/ContextMenu/ItemProviders/FileProvider.php+20 −5
- typo3/sysext/filelist/Classes/Hook/BackendControllerHook.phpdeleted+0 −45
- typo3/sysext/filelist/Resources/Public/JavaScript/ContextMenuActions.js+1 −1
- typo3/sysext/filelist/ext_localconf.php+0 −1
- typo3/sysext/impexp/Classes/ContextMenu/ItemProvider.php+18 −1
- typo3/sysext/impexp/Classes/Hook/BackendControllerHook.phpdeleted+0 −45
- typo3/sysext/impexp/Resources/Public/JavaScript/ContextMenuActions.js+1 −1
- typo3/sysext/impexp/ext_localconf.php+0 −1
Review log 1013
-
Oli Bartsch uploaded patch set 1 09/06/21, 15:50
-
core-ci voted on patch set 1 V +1 09/06/21, 16:11 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16334
-
Oli Bartsch updated the commit message in patch set 2 09/06/21, 20:05
-
Oli Bartsch updated the commit message in patch set 3 09/06/21, 20:05
-
core-ci voted on patch set 2 V +1 09/06/21, 20:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16350
-
core-ci voted on patch set 3 V +1 09/06/21, 20:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16351
-
Benni Mack commented on patch set 3 09/07/21, 15:28
-
Oli Bartsch commented on patch set 3 09/07/21, 16:30
ContextMenuActions.ts:123ReplyThe patch is just about removing the unnecessary BackendController hooks. "FormEngine.moduleUrl" is always set in BackendController, thus no need to duplicate this information in the Provider class. -
Benni Mack voted on patch set 3 V +1 CR +1 09/08/21, 05:52
-
Jochen Roth voted on patch set 3 V +1 CR +1 09/09/21, 09:31
-
Christian Kuhn voted on patch set 3 CR +2 09/09/21, 09:32
-
Christian Kuhn voted on patch set 3 V +2 09/09/21, 09:32
-
Christian Kuhn merged patch set 4 09/09/21, 09:32
ContextMenuActions.ts:123