Review main Merged

70914[TASK] Avoid using hook for context menu settings

Oli Bartsch CR +2 V +2 Normal +57 −111 updated 09/09/21, 09:32

Commit message

It's possible to assign additional attributes
to context menu items. Those attributes are
then available in the corresponding JavaScript
callback method.

Therefore, there is no need to add settings,
only used in the callback methods, globally
via BackendController hooks.

This patch removes such hook usages from
EXT:filelist and EXT:impexp, while adding
the corresponding settings as attributes
to the context menu items.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1013

  1. Oli Bartsch uploaded patch set 1 09/06/21, 15:50

  2. core-ci voted on patch set 1 V +1 09/06/21, 16:11 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16334

  3. Oli Bartsch updated the commit message in patch set 2 09/06/21, 20:05

  4. Oli Bartsch updated the commit message in patch set 3 09/06/21, 20:05

  5. core-ci voted on patch set 2 V +1 09/06/21, 20:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16350

  6. core-ci voted on patch set 3 V +1 09/06/21, 20:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16351

  7. Benni Mack commented on patch set 3 09/07/21, 15:28

    ContextMenuActions.ts:123

    maybe here as well?
  8. Oli Bartsch commented on patch set 3 09/07/21, 16:30

    ContextMenuActions.ts:123 Reply

    The patch is just about removing the unnecessary BackendController hooks. "FormEngine.moduleUrl" is always set in BackendController, thus no need to duplicate this information in the Provider class.
  9. Benni Mack voted on patch set 3 V +1 CR +1 09/08/21, 05:52

  10. Jochen Roth voted on patch set 3 V +1 CR +1 09/09/21, 09:31

  11. Christian Kuhn voted on patch set 3 CR +2 09/09/21, 09:32

  12. Christian Kuhn voted on patch set 3 V +2 09/09/21, 09:32

  13. Christian Kuhn merged patch set 4 09/09/21, 09:32