Review main Merged

70916[TASK] Update MFA and QR-code related composer dependencies

Oliver Hader CR +2 V +2 Easy +15 −15 updated 09/06/21, 16:58

Commit message

Composer commands:
  composer req 'christian-riesen/base32:^1.6'; \
  composer update 'bacon/bacon-qr-code' --with-all-dependencies

Output:
  - Upgrading christian-riesen/base32 (1.5.2 => 1.6.0)
  - Upgrading bacon/bacon-qr-code (2.0.3 => 2.0.4)

References:
* https://github.com/ChristianRiesen/base32/releases/tag/1.6.0
  "Major bugfix [...] please require at a minimum ^1.6 in your project"

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 58

  1. Oliver Hader uploaded patch set 1 09/06/21, 16:11

  2. core-ci voted on patch set 1 V -1 09/06/21, 16:26 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16338

  3. Oliver Hader uploaded patch set 2 09/06/21, 16:37

  4. core-ci commented on patch set 1 09/06/21, 16:38 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16338

  5. core-ci voted on patch set 2 V +1 09/06/21, 16:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16341

  6. Oli Bartsch voted on patch set 2 V +1 CR +1 09/06/21, 16:53

  7. Oliver Hader voted on patch set 2 V +2 CR +2 09/06/21, 16:58

  8. Oliver Hader merged patch set 3 09/06/21, 16:58