Review main Merged

70955[BUGFIX] Loosen constraint to guzzlehttp/psr7

Andreas Kienast CR +2 V +2 Easy +3 −3 updated 09/08/21, 08:22

Commit message

The first release of the v2 branch of guzzlehttp/psr7 was in
June 30th 2021, which is around two months from now at the time of
writing this commit message.

Many 3rd party libraries are not compatible to version 2.0 of
guzzlehttp/psr7 yet, which makes updates impossible without using nasty
hacks.

For this reason, the constraint is loosened to allow both, 1.7 and 2.0
of guzzlehttp/psr7.

Executed commands:

  composer req guzzlehttp/psr7:"^1.7.0 || ^2.0"
  composer req guzzlehttp/psr7:"^1.7.0 || ^2.0" -d typo3/sysext/core --no-update

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Frank Nägler +1
    • Riny van Tiggelen +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1113

  1. Andreas Kienast uploaded patch set 1 09/07/21, 10:47

  2. core-ci voted on patch set 1 V +1 09/07/21, 11:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16372

  3. Oliver Klee voted on patch set 1 CR +1 09/07/21, 11:05

  4. Andreas Kienast updated the commit message in patch set 2 09/07/21, 11:08

  5. Oliver Klee voted on patch set 2 CR +1 09/07/21, 11:21

  6. core-ci voted on patch set 2 V +1 09/07/21, 11:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16373

  7. Riny van Tiggelen voted on patch set 2 CR +1 09/07/21, 14:35

  8. Wouter Wolters voted on patch set 2 CR +1 09/07/21, 17:38

  9. Benni Mack voted on patch set 2 V +1 CR +1 09/07/21, 18:32

  10. Frank Nägler voted on patch set 2 CR +1 09/08/21, 07:38

  11. Frank Nägler voted on patch set 2 V +1 09/08/21, 08:22

  12. Andreas Kienast voted on patch set 2 V +2 CR +2 09/08/21, 08:22

  13. Andreas Kienast merged patch set 3 09/08/21, 08:22