70956[TASK] Deprecate extbase ControllerContext
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Jochen Roth +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Jochen Roth +1
- Benni Mack +1
- core-ci +1 CI
Issues 5
- Task #95139Deprecate extbase ControllerContext
- Task #93019Deprecate ControllerContext::getUriBuilder()
- Task #93016Deprecate ControllerContext::getFlashMessageQueue()
- Feature #94428Extbase Request implements ServerRequestInterface
- Bug #92826Avoid using ControllerContext, and use Extbase Request instead
Files 25
- typo3/sysext/backend/Classes/View/BackendTemplateView.php+1 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-95139-ExtbaseControllerContext.rstnew+58 −0
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+5 −0
- typo3/sysext/extbase/Classes/Mvc/Controller/ControllerContext.php+2 −4
- typo3/sysext/extbase/Classes/Mvc/View/JsonView.php+2 −0
- typo3/sysext/extbase/Classes/Mvc/View/ViewInterface.php+1 −0
- typo3/sysext/extbase/Configuration/Services.yaml+1 −0
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Extension/action_controller_test/Classes/Controller/TestController.php+6 −0
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ActionControllerTest.php+3 −0
- typo3/sysext/fluid/Classes/Core/Rendering/RenderingContext.php+11 −4
- typo3/sysext/fluid/Classes/View/AbstractTemplateView.php3+6 −0
- typo3/sysext/fluid/Tests/Unit/Core/Rendering/RenderingContextTest.php+1 −17
- typo3/sysext/fluid/Tests/UnitDeprecated/Core/Rendering/RenderingContextTest.phpnew+59 −0
- typo3/sysext/form/Classes/Controller/FormEditorController.php+1 −0
- typo3/sysext/form/Classes/Domain/Finishers/FinisherContext.php+3 −1
- typo3/sysext/form/Classes/Domain/Model/FormDefinition.php+1 −1
- typo3/sysext/form/Classes/Domain/Renderer/AbstractElementRenderer.php+2 −0
- typo3/sysext/form/Classes/Domain/Renderer/FluidFormRenderer.php+1 −0
- typo3/sysext/form/Classes/Domain/Renderer/RendererInterface.php+1 −0
Show 5 more files
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+4 −2
- typo3/sysext/form/Documentation/I/ApiReference/Index.rst+0 −22
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+5 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+77 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php+25 −0
Review log 1521
-
Christian Kuhn uploaded patch set 1 09/07/21, 13:23
-
core-ci voted on patch set 1 V -1 09/07/21, 13:39 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16376
-
Christian Kuhn uploaded patch set 2 09/07/21, 13:54
-
core-ci voted on patch set 2 V -1 09/07/21, 13:58 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16378
-
Christian Kuhn uploaded patch set 3 09/07/21, 16:02
-
core-ci voted on patch set 3 V +1 09/07/21, 16:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16380
-
Christian Kuhn uploaded patch set 4 09/07/21, 19:42
-
core-ci voted on patch set 4 V +1 09/07/21, 20:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16393
-
Christian Kuhn uploaded patch set 5 09/08/21, 09:27
-
core-ci voted on patch set 5 V +1 09/08/21, 09:47 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16406
-
Benni Mack voted on patch set 5 V +1 CR +1 09/08/21, 16:01
-
Oli Bartsch commented on patch set 5 CR -1 09/08/21, 16:31
-
Christian Kuhn commented on patch set 5 09/08/21, 16:35
AbstractTemplateView.php:92Replyah true. i'll drop the trigger_error in renderingContext, too. -
Christian Kuhn commented on patch set 5 09/08/21, 16:39
AbstractTemplateView.php:92Replyor even better: i'll setRequest() on RenderingContext before. -
Christian Kuhn uploaded patch set 6 09/08/21, 16:39
-
core-ci voted on patch set 6 V +1 09/08/21, 16:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16422
-
Benni Mack voted on patch set 6 V +1 CR +1 09/09/21, 09:01
-
Jochen Roth voted on patch set 6 V +1 CR +1 09/09/21, 09:07
-
Oli Bartsch voted on patch set 6 V +1 CR +1 09/09/21, 09:07
-
Christian Kuhn voted on patch set 6 V +2 CR +2 09/09/21, 09:09
-
Christian Kuhn merged patch set 7 09/09/21, 09:09
AbstractTemplateView.php:92