Review main Merged

70956[TASK] Deprecate extbase ControllerContext

Christian Kuhn CR +2 V +2 Hard +278 −53 updated 09/09/21, 09:09

Commit message

The Extbase ControllerContext is a dependency between
Extbase and Fluid to communicate state. It is wired
into various view related classes.

To further decouple fluid from extbase, this class
needs to fall. A couple of previous patches deprecated
parts of the class already, this patch deprecates the
rest.

The fluid RenderingContext can be used in view helpers
in almost all cases as substitution, especially since
extbase request implements PSR-7 ServerRequestInterface.

The core itself has no direct usages of ControllerContext
anymore, it is only moved around at various places.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 5

Files 25

Show 5 more files

Review log 1521

  1. Christian Kuhn uploaded patch set 1 09/07/21, 13:23

  2. core-ci voted on patch set 1 V -1 09/07/21, 13:39 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16376

  3. Christian Kuhn uploaded patch set 2 09/07/21, 13:54

  4. core-ci voted on patch set 2 V -1 09/07/21, 13:58 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16378

  5. Christian Kuhn uploaded patch set 3 09/07/21, 16:02

  6. core-ci voted on patch set 3 V +1 09/07/21, 16:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16380

  7. Christian Kuhn uploaded patch set 4 09/07/21, 19:42

  8. core-ci voted on patch set 4 V +1 09/07/21, 20:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16393

  9. Christian Kuhn uploaded patch set 5 09/08/21, 09:27

  10. core-ci voted on patch set 5 V +1 09/08/21, 09:47 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16406

  11. Benni Mack voted on patch set 5 V +1 CR +1 09/08/21, 16:01

  12. Oli Bartsch commented on patch set 5 CR -1 09/08/21, 16:31

    AbstractTemplateView.php:92

    This now triggers deprecation log entries.
  13. Christian Kuhn commented on patch set 5 09/08/21, 16:35

    AbstractTemplateView.php:92 Reply

    ah true. i'll drop the trigger_error in renderingContext, too.
  14. Christian Kuhn commented on patch set 5 09/08/21, 16:39

    AbstractTemplateView.php:92 Reply

    or even better: i'll setRequest() on RenderingContext before.
  15. Christian Kuhn uploaded patch set 6 09/08/21, 16:39

  16. core-ci voted on patch set 6 V +1 09/08/21, 16:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16422

  17. Benni Mack voted on patch set 6 V +1 CR +1 09/09/21, 09:01

  18. Jochen Roth voted on patch set 6 V +1 CR +1 09/09/21, 09:07

  19. Oli Bartsch voted on patch set 6 V +1 CR +1 09/09/21, 09:07

  20. Christian Kuhn voted on patch set 6 V +2 CR +2 09/09/21, 09:09

  21. Christian Kuhn merged patch set 7 09/09/21, 09:09